-
Notifications
You must be signed in to change notification settings - Fork 50
Transport improvements from 2025-W32 #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dd599af
to
f6df7e4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
=======================================
- Coverage 75.5% 74.8% -0.7%
=======================================
Files 270 270
Lines 22093 22153 +60
=======================================
- Hits 16687 16592 -95
- Misses 5406 5561 +155
🚀 New features to boost your workflow:
|
f6df7e4
to
69a7daa
Compare
88b9ca1
to
fe79f4c
Compare
ec47622
to
e6a803c
Compare
e6a803c
to
1bcaae2
Compare
811707f
to
fd3589c
Compare
fd3589c
to
6ed184d
Compare
Increase values for n=R12_WEU and some other regions to test effect on LDV CAP/CAP_NEW over time.
- Experimental: use higher values for R12_WEU - Revert to more realistic values.
6ed184d
to
9f5e0f8
Compare
- Replace usage of "RAIL", "ROAD" that was ambiguous with e.g. "P RAIL". - Update .transport.other. - Update input data files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests for Python 3.9 and upstream version 3.8.0 are not passing, is that intentional?
Ah, no—I seem to have used some features that were not advertised as being added in 3.10 or later. Will adjust. |
Increase values for n=R12_WEU and some other regions to test effect on LDV CAP/CAP_NEW over time.
- Experimental: use higher values for R12_WEU - Revert to more realistic values.
- Move .use_scenario_code() method to .code setter. - Document ScenarioCodeAnnotations. - Adjust usage and tests.
- MultiFile is a common parent class for existing PDT_CAP and LoadFactorLDV. - Use Config.label property to construct file names. - Remove duplicative logic in .demand.prepare_computer(). - Use LoadFactorLDV in .build.add_exogenous_data(). - Add tests.
These are now added by LoadFactorLDV.transform().
- Add to project scenario code list. - Add to transport scenario code list. - Adjust tests.
- Format files. - Remove former DIGSY-BEST.csv in favour of DIGSY-BEST-C.csv, etc.
5367a3d
to
6e96b04
Compare
@glatterf42 I think I ran into python/cpython#136672 —this affected my local (Ubuntu) copy of the 3.13.3 docs, but the updated 3.13.7 version on docs.python.org has the notification. I've adjusted the code to work with earlier Pythons, so tests are now passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm since tests are all passing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- Update elasticity-f values for scenario=DIGSY-BEST-C. - Add values for scenario=DIGSY-*-S.
Increase values for n=R12_WEU and some other regions to test effect on LDV CAP/CAP_NEW over time.
- Experimental: use higher values for R12_WEU - Revert to more realistic values.
load-factor-ldv.csv
to a subdirectory structure parallel topdt-cap/{label}.csv
.How to review
@r-aneeque
@glatterf42
PR checklist