-
Notifications
You must be signed in to change notification settings - Fork 9
Remove inheritance of InputFile on Mesh #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,10 +112,10 @@ def test_meshpy_rotations(assert_results_equal): | |
"""Check if the Mesh function rotation gives the same results as rotating | ||
each node it self.""" | ||
|
||
mesh_1 = InputFile() | ||
mesh_1 = Mesh() | ||
create_test_mesh(mesh_1) | ||
|
||
mesh_2 = InputFile() | ||
mesh_2 = Mesh() | ||
create_test_mesh(mesh_2) | ||
Comment on lines
-115
to
119
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @isteinbrecher one general question I wanted to discuss before proceeding to adjust the tests In my opinion, in the future MeshPy should work without fourcipp, i.e., a 4C input file. For that it would be ideal if we could run tests on Meshes. Currently we are not able to compare meshes within the testing framework. Do you share this opinion that we should test it without any overhead? Maybe you have additional ideas, etc. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we share this opinion I would add an option that we can compare individual Meshes in our testing suite. This somehow contradicts our discussion we had yesterday - we said we mainly wanted to focus on tests with reference files. But in my opinion it's not that nice that we will always depend on fourcipp. Maybe create a really generic input file which just dumps the raw data to yaml/json files and compare these? |
||
|
||
# Set the seed for the pseudo random numbers | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And as a final note: I tested the overall working with my minimal example from #318 and everything worked out of the box as we discussed it.