Skip to content

Decentralization of configuration parameters phase 1 - new aggregator route #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Oct 29, 2025
Merged

Decentralization of configuration parameters phase 1 - new aggregator route #2741

merged 25 commits into from
Oct 29, 2025

Conversation

@turmelclem
Copy link
Collaborator

@turmelclem turmelclem commented Oct 17, 2025 •
edited
Loading

Content

This pull request :

  • add /protocol-configuration route in aggregator to expose protocol configurations by epoch
  • fix dependency injenction of HttpMithrilNetworkConfigurationProvider by removing construction of HTTPAgregatorClient in it
  • refactor HttpMithrilNetworkConfigurationProvider to take a ProtocolConfigurationRetriever
  • refactor MithrilNetworkConfiguration to take a window of three epochs
  • reproduce behavior of Aggregator's epoch-settings route to apply corresponding epoch offset
  • in the signer, remove mapping of attributes registration_protocol_parameters and cardano_transactions_signing_config from /epoch-settings route since it will be deprecated in the future

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Relates to #2692

@turmelclem turmelclem changed the title Decentralization of configuration parameters phase 1 - new aggregator route to expose protocol config by epoch Decentralization of configuration parameters phase 1 - new aggregator route Oct 17, 2025
@turmelclem turmelclem self-assigned this Oct 17, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 17, 2025 •
edited
Loading

Test Results

    4 files  ± 0    168 suites  ±0   23m 29s ⏱️ -42s
2 256 tests  -  8  2 256 ✅  -  8  0 💤 ±0  0 ❌ ±0 
6 941 runs   - 58  6 941 ✅  - 58  0 💤 ±0  0 ❌ ±0 

Results for commit 6a4547c. ± Comparison against base commit 3063c3e.

This pull request removes 25 and adds 17 tests. Note that renamed tests count towards both. 
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_ko_500
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_ko_json_serialization
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_ok_200
mithril-protocol-config ‑ aggregator_client::tests::aggregator_features::test_aggregator_features_timeout
mithril-protocol-config ‑ aggregator_client::tests::epoch_settings::test_epoch_settings_ko_500
mithril-protocol-config ‑ aggregator_client::tests::epoch_settings::test_epoch_settings_ok_200
mithril-protocol-config ‑ aggregator_client::tests::epoch_settings::test_epoch_settings_timeout
mithril-protocol-config ‑ aggregator_client::tests::test_4xx_errors_are_handled_as_remote_server_logical
mithril-protocol-config ‑ aggregator_client::tests::test_5xx_errors_are_handled_as_remote_server_technical
mithril-protocol-config ‑ aggregator_client::tests::test_non_4xx_or_5xx_errors_are_handled_as_unhandled_status_code_and_contains_response_text
…

mithril-aggregator ‑ http_server::routes::protocol_configuration_routes::tests::test_protocol_configuration_get_ko_500
mithril-aggregator ‑ http_server::routes::protocol_configuration_routes::tests::test_protocol_configuration_get_ok
mithril-aggregator ‑ http_server::routes::protocol_configuration_routes::tests::test_protocol_configuration_return_404_when_no_configuration_found
mithril-aggregator ‑ services::message::tests::protocol_configuration::get_protocol_configuration_message
mithril-aggregator ‑ services::message::tests::protocol_configuration::get_protocol_configuration_message_return_none_if_epoch_not_found
mithril-aggregator ‑ services::message::tests::protocol_configuration::get_protocol_configuration_message_with_cardano_transactions_enabled
mithril-aggregator ‑ services::message::tests::protocol_configuration::get_protocol_configuration_message_with_multiple_epochs_settings_stored
mithril-aggregator ‑ services::message::tests::protocol_configuration::get_protocol_configuration_message_without_cardano_transactions_does_not_return_signing_config
mithril-protocol-config ‑ http_client::http_impl::tests::test_get_network_configuration_retrieve_configurations_for_aggregation_next_aggregation_and_registration
mithril-protocol-config ‑ test::double::configuration_provider::tests::test_get_network_configuration
…

♻️ This comment has been updated with latest results.

@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch 2 times, most recently from 1ee5c10 to f2e18f0 Compare October 17, 2025 14:03
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2025
View reviewed changes
@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch from 907be17 to 7deb45e Compare October 20, 2025 14:15
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 20, 2025
View reviewed changes
@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch 4 times, most recently from 31e5c40 to 22ad61d Compare October 22, 2025 09:03
@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch from 2e0f345 to 54921dc Compare October 24, 2025 15:41
@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch from 447134a to 30b9fa4 Compare October 27, 2025 10:57
@turmelclem turmelclem marked this pull request as ready for review October 27, 2025 14:37
jpraynaud
jpraynaud reviewed Oct 27, 2025
View reviewed changes
@turmelclem turmelclem mentioned this pull request Oct 27, 2025
Merged
14 tasks
Alenar
Alenar approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch from 16fa0cb to 4099356 Compare October 28, 2025 10:10
@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch from e60169d to 7c45773 Compare October 28, 2025 17:18
@turmelclem
refactor(protocol-config, signer): rename ProtocolConfigurationRetrie…
ad9c6b9 
…ver to ProtocolConfigurationRetrieverFromAggregator
@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch from 7c45773 to ad9c6b9 Compare October 28, 2025 17:30
@turmelclem turmelclem requested a review from jpraynaud October 29, 2025 08:08
@turmelclem
feature(openAPI): add missing CardanoTransactions to signed entity of…
3673d5b 
… root route, improve test with missing signed entity types
@turmelclem
chore: upgrade crate versions and openapi.yaml version
439d0a0 
* mithril-protocol-config from `0.1.0` to `0.1.1`
* mithril-aggregator from `0.7.90` to `0.7.91`
* mithril-common from `0.6.25` to `0.6.26`
* mithril-relay from `0.1.53` to `0.1.54`
* mithril-signer from `0.2.273` to `0.2.274`
* openapi.yaml from `0.1.54` to `0.1.55`
@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch from 8e556f6 to 439d0a0 Compare October 29, 2025 08:36
jpraynaud
jpraynaud approved these changes Oct 29, 2025
View reviewed changes
@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch from c23d12c to 509f2f0 Compare October 29, 2025 10:03
@turmelclem turmelclem force-pushed the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch from 509f2f0 to 6a4547c Compare October 29, 2025 10:16
@turmelclem turmelclem merged commit ace8c04 into main Oct 29, 2025
41 checks passed
@turmelclem turmelclem deleted the ctl/2692-new-aggregator-route-to-expose-protocol-config-by-epoch branch October 29, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@turmelclem turmelclem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@turmelclem @Alenar @jpraynaud