fix(app): firebase-js-sdk bump 11.3.1 > 11.10.0 #8596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks like this has potential! Didn't seem to joke on the jest tests, android + other e2e timed out though, which is unexpected. Re-ran both of them (looks like it's the 3rd attempt at other e2e...) 🤔 |
note: firebase-js-sdk firestore new versions have started using 'URL.hostname',
but this is not implemented in react-native until react-native 0.80
so we need a URL polyfill in order to support it
- no arrow functions for describe or it - no unused variable names unless prefixed with '_'
mikehardy
approved these changes
Jul 6, 2025
There was a problem hiding this comment.
This passed local testing after I reproduced the CI errors, localized it to missing URL.hostname implementation in react-native context, and installed react-native-url-polyfill (in firestore only, it's only used there apparently)
I think that's okay but I'm open to being wrong on that one
mikehardy
added
the
Workflow: Needs Second Review
russellwheatley
approved these changes
Jul 7, 2025
mikehardy
removed
the
Workflow: Needs Second Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter