Skip to content

fix(app): firebase-js-sdk bump 11.3.1 > 11.10.0 #8596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

Conversation

MichaelVerdon
Copy link
Collaborator

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2025 5:36pm

@mikehardy
Copy link
Collaborator

Looks like this has potential! Didn't seem to joke on the jest tests, android + other e2e timed out though, which is unexpected. Re-ran both of them (looks like it's the 3rd attempt at other e2e...) 🤔

MichaelVerdon and others added 2 commits July 6, 2025 12:27
note: firebase-js-sdk firestore new versions have started using 'URL.hostname',
      but this is not implemented in react-native until react-native 0.80

      so we need a URL polyfill in order to support it
- no arrow functions for describe or it
- no unused variable names unless prefixed with '_'
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passed local testing after I reproduced the CI errors, localized it to missing URL.hostname implementation in react-native context, and installed react-native-url-polyfill (in firestore only, it's only used there apparently)

I think that's okay but I'm open to being wrong on that one

@mikehardy mikehardy requested a review from russellwheatley July 6, 2025 17:40
@mikehardy mikehardy added the Workflow: Needs Second Review Waiting on a second review before merge label Jul 6, 2025
@mikehardy mikehardy removed the Workflow: Needs Second Review Waiting on a second review before merge label Jul 7, 2025
@mikehardy mikehardy merged commit 0e35121 into main Jul 7, 2025
17 of 18 checks passed
@mikehardy mikehardy deleted the js-sdk-bump branch July 7, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants