Skip to content

fix(app): firebase-js-sdk bump 11.3.1 > 11.10.0 #8596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"react-native": "*"
},
"dependencies": {
"firebase": "11.3.1"
"firebase": "11.10.0"
},
"devDependencies": {
"@react-native-async-storage/async-storage": "^2.1.2",
Expand Down
6 changes: 6 additions & 0 deletions packages/firestore/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ import version from './version';
import fallBackModule from './web/RNFBFirestoreModule';
import FirestorePersistentCacheIndexManager from './FirestorePersistentCacheIndexManager';

// react-native at least through 0.77 does not correctly support URL.host, which
// is needed by firebase-js-sdk. It appears that in 0.80+ it is supported, so this
// (and the package.json entry for this package) should be removed when the minimum
// supported version of react-native is 0.80 or higher.
import 'react-native-url-polyfill/auto';

const namespace = 'firestore';

const nativeModuleName = [
Expand Down
3 changes: 3 additions & 0 deletions packages/firestore/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
"realtime",
"firestore"
],
"dependencies": {
"react-native-url-polyfill": "2.0.0"
},
"peerDependencies": {
"@react-native-firebase/app": "22.2.1"
},
Expand Down
13 changes: 8 additions & 5 deletions tests/.jetrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,23 @@ module.exports = {
async before(config) {
return config;
},
async after(config) {
async after(_config) {
// no-op
},
},
ios: {
async before(config) {
return config;
},
async after(config) {
async after(_config) {
// no-op
},
},
macos: {
async before(config) {
try {
execSync(`killall "io.invertase.testing"`);
} catch (e) {
} catch (_e) {
// noop
}
const macApp = spawn(
Expand All @@ -47,23 +47,26 @@ module.exports = {
}
if (macOsRetries < 3) {
macOsRetries++;
// eslint-disable-next-line no-console
console.log('App crashed, retrying macOS app tests...');
this.before(config);
return;
} else {
// eslint-disable-next-line no-console
console.error('macOS app failed to start, exiting...');
process.exit(1);
}
});
macApp.on('spawn', () => {
// eslint-disable-next-line no-console
console.log('[💻] macOS app started');
});
return config;
},
async after(config) {
async after(_config) {
try {
execSync(`killall "io.invertase.testing"`);
} catch (e) {
} catch (_e) {
// noop
}
},
Expand Down
8 changes: 4 additions & 4 deletions tests/e2e/firebase.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
*/
const { execSync, spawn } = require('child_process');

describe('Jet Tests', () => {
jest.retryTimes(3, { logErrorsBeforeRetry: true });
describe('Jet Tests', function () {
jest.retryTimes(0, { logErrorsBeforeRetry: true });

it('runs all tests', async () => {
it('runs all tests', async function () {
return new Promise(async (resolve, reject) => {
const platform = detox.device.getPlatform();
const jetProcess = spawn('yarn', ['jet', `--target=${platform}`, '--coverage'], {
Expand Down Expand Up @@ -81,7 +81,7 @@ afterAll(async function () {

try {
await device.terminateApp();
} catch (e) {
} catch (_) {
// No-op
}
});
Loading
Loading