Skip to content

Conversation

johnsimeroth
Copy link

Description

This PR implements the uploadBytes storage function for the modular SDK, one of several unimplemented methods mentioned in #7483.

Related issues

#7483

Release Summary

Adds missing storage.uploadBytes implementation

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change. (N/A)
  • This is a breaking change;
    • Yes
    • No

Test Plan

No new tests, but all existing storage tests still pass. I would have mirrored any tests for uploadBytesResumable, but I didn't see any for that either.

image

Think react-native-firebase is great? Please consider supporting the project with any of the below:

🔥 My first PR here, LMK what you'd like to see different and I'm happy to make changes.

Copy link

vercel bot commented Sep 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-native-firebase Ready Ready Preview Comment Sep 13, 2025 6:13pm

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2025

CLA assistant check
All committers have signed the CLA.

@MichaelVerdon
Copy link
Collaborator

Can you write a test for this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants