Skip to content

fix: implement uploadBytes for storage modular sdk #8696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: implement uploadBytes for storage modular sdk #8696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions packages/storage/lib/modular/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,28 @@ export function updateMetadata(storageRef, metadata) {
* @param metadata - A Storage `SettableMetadata` instance to update. Optional.
* @returns {Promise<TaskResult>}
*/
// eslint-disable-next-line
export async function uploadBytes(storageRef, data, metadata) {
throw new Error('`uploadBytes()` is not implemented');
const task = uploadBytesResumable(storageRef, data, metadata);
return new Promise((resolve, reject) => {
task.on('state_changed', taskSnapshot => {
switch (taskSnapshot.state) {
case 'running':
break;
case 'paused':
task.resume();
break;
case 'success':
resolve({ ref: taskSnapshot.ref, metadata: taskSnapshot.metadata });
break;
case 'cancelled':
case 'error':
reject(taskSnapshot.error);
break;
default:
throw new Error(`Unhandled task state in uploadBytes: ${taskSnapshot.state}`);
}
});
});
}

/**
Expand Down
Loading