Skip to content

Conversation

@liamawhite
Copy link
Member

Every other CRD has this annotation set so add it to WorkloadGroup.

Noticed this as I was root causing why this CRD was missing from one of our clusters.

@liamawhite liamawhite requested a review from a team as a code owner October 31, 2025 17:02
@istio-policy-bot
Copy link

😊 Welcome @liamawhite! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2025
@liamawhite liamawhite added cherrypick/release-1.26 Set this label on a PR to auto-merge it to the release-1.26 branch cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch cherrypick/release-1.28 Set this label on a PR to auto-merge it to the release-1.28 branch labels Oct 31, 2025
@howardjohn
Copy link
Member

Nice find 👍

@istio-testing istio-testing merged commit 26ab50c into istio:master Oct 31, 2025
5 checks passed
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #3593

@istio-testing
Copy link
Collaborator

In response to a cherrypick label: #3592 failed to apply on top of branch "release-1.26":

Applying: Instruct helm to keep workload groups around on deletion
Using index info to reconstruct a base tree...
M	kubernetes/customresourcedefinitions.gen.yaml
M	networking/v1/workload_group_alias.gen.go
M	networking/v1alpha3/workload_group.pb.go
M	networking/v1alpha3/workload_group.proto
M	networking/v1beta1/workload_group_alias.gen.go
Falling back to patching base and 3-way merge...
Auto-merging networking/v1beta1/workload_group_alias.gen.go
CONFLICT (content): Merge conflict in networking/v1beta1/workload_group_alias.gen.go
Auto-merging networking/v1alpha3/workload_group.proto
CONFLICT (content): Merge conflict in networking/v1alpha3/workload_group.proto
Auto-merging networking/v1alpha3/workload_group.pb.go
CONFLICT (content): Merge conflict in networking/v1alpha3/workload_group.pb.go
Auto-merging networking/v1/workload_group_alias.gen.go
CONFLICT (content): Merge conflict in networking/v1/workload_group_alias.gen.go
Auto-merging kubernetes/customresourcedefinitions.gen.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Instruct helm to keep workload groups around on deletion

@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new issue created for failed cherrypick: #3594

@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #3595

liamawhite added a commit to liamawhite/api that referenced this pull request Oct 31, 2025
* Instruct helm to keep workload groups around on deletion

* Add release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick/release-1.26 Set this label on a PR to auto-merge it to the release-1.26 branch cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch cherrypick/release-1.28 Set this label on a PR to auto-merge it to the release-1.28 branch size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants