-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Update dependencies #45071
base: 5.3-dev
Are you sure you want to change the base?
[5.3] Update dependencies #45071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a code review on all direct dependencies, sa11y is hard to review, many language changes and precompiled/minified files. Also checked a couple uncommon transient dependencies.
I have tested this item ✅ successfully on 2d6b088 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071. |
@laoneo Could you update this PR for the new version 3.1.0 of the filesystem framework? https://github.com/joomla-framework/filesystem/releases/tag/3.1.0 |
done |
Thanks. That was quick. |
I have tested this item ✅ successfully on caa3c70 It all worked, and the comparison of the packages has not shown any unexpected differences, i.e. our js and css compile works as before. On the installation with the PR applied, there were no unexpected new errors in the PHP error log or the developer console. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071. |
@laoneo Why have you invalidated the human test count by an unnecessary branch update? |
It is then already up to date. |
That still doesn’t explain why you don’t restore the human test with the „alter test“ button in the issue tracker after the branch update. |
rtc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071. |
Not really right as @brianteeman ‘s test was invalidated by a later commit which updated again some dependencies. |
back to pending then This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071. |
It still needs to restore my test result in the issue tracker so that my test is still counted because the commit after my test was just a clean branch update. I will do that for now, but plese remember doing that yourself next time when you update the branch of a PR which has tests but is not RTC yet so you don't cause additional work for other maintainers. Thanks. |
Thanks |
@brianteeman Could you repeat your test (or review)? The PR has received an update meanwhile. Thanks in advance. |
esbuild <=0.24.2 |
Well, it requires the force parameter and is a breaking change, so we can’t do that, I think. |
And it is on development only anyway, not being shipped with the public installable package. |
Updates the dependencies.