Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Update dependencies #45071

Open
wants to merge 6 commits into
base: 5.3-dev
Choose a base branch
from
Open

[5.3] Update dependencies #45071

wants to merge 6 commits into from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Mar 5, 2025

Updates the dependencies.

@joomla-cms-bot joomla-cms-bot added Composer Dependency Changed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Mar 5, 2025
Copy link
Member

@HLeithner HLeithner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a code review on all direct dependencies, sa11y is hard to review, many language changes and precompiled/minified files. Also checked a couple uncommon transient dependencies.

@laoneo laoneo changed the title Update dependencies [5.3] Update dependencies Mar 5, 2025
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 2d6b088


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071.

@richard67
Copy link
Member

@laoneo Could you update this PR for the new version 3.1.0 of the filesystem framework? https://github.com/joomla-framework/filesystem/releases/tag/3.1.0

@laoneo
Copy link
Member Author

laoneo commented Mar 7, 2025

done

@richard67
Copy link
Member

Thanks. That was quick.

@richard67
Copy link
Member

richard67 commented Mar 7, 2025

I have tested this item ✅ successfully on caa3c70

I've reviewed the changes and have compared the full install zip packages created without and with this PR, have compared the console output from both builds, and have tested an installation with the PR applied and finally a live update of that installation to the patched package for this PR.

It all worked, and the comparison of the packages has not shown any unexpected differences, i.e. our js and css compile works as before.

On the installation with the PR applied, there were no unexpected new errors in the PHP error log or the developer console.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071.

@richard67
Copy link
Member

@laoneo Why have you invalidated the human test count by an unnecessary branch update?

@laoneo
Copy link
Member Author

laoneo commented Mar 9, 2025

It is then already up to date.

@richard67
Copy link
Member

That still doesn’t explain why you don’t restore the human test with the „alter test“ button in the issue tracker after the branch update.

@laoneo
Copy link
Member Author

laoneo commented Mar 9, 2025

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 9, 2025
@richard67
Copy link
Member

rtc

Not really right as @brianteeman ‘s test was invalidated by a later commit which updated again some dependencies.

@laoneo laoneo removed the RTC This Pull Request is Ready To Commit label Mar 9, 2025
@laoneo
Copy link
Member Author

laoneo commented Mar 9, 2025

back to pending then


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45071.

@richard67
Copy link
Member

back to pending then

It still needs to restore my test result in the issue tracker so that my test is still counted because the commit after my test was just a clean branch update. I will do that for now, but plese remember doing that yourself next time when you update the branch of a PR which has tests but is not RTC yet so you don't cause additional work for other maintainers. Thanks.

@laoneo
Copy link
Member Author

laoneo commented Mar 9, 2025

Thanks

@richard67
Copy link
Member

@brianteeman Could you repeat your test (or review)? The PR has received an update meanwhile. Thanks in advance.

@brianteeman
Copy link
Contributor

esbuild <=0.24.2
Severity: moderate
esbuild enables any website to send any requests to the development server and read the response - GHSA-67mh-4wv8-2f99
fix available via npm audit fix --force
Will install [email protected], which is a breaking change

@richard67
Copy link
Member

Well, it requires the force parameter and is a breaking change, so we can’t do that, I think.

@laoneo
Copy link
Member Author

laoneo commented Mar 10, 2025

And it is on development only anyway, not being shipped with the public installable package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Composer Dependency Changed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants