-
Notifications
You must be signed in to change notification settings - Fork 264
jQuery.get:jQuery.post: Document issues with data: null
with 3 params
#1208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
timmywil
reviewed
Oct 17, 2022
gibson042
approved these changes
Oct 18, 2022
4ee332d
to
03bdec9
Compare
03bdec9
to
66abf44
Compare
66abf44
to
d8fa4f5
Compare
d8fa4f5
to
5e558e0
Compare
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Mar 17, 2025
Also, fix `mock.php` formatting to not fail the `jQuery.get( String, null, String )` test in PHP mode. Ref jquerygh-4989 Ref jquery/api.jquery.com#1208
2 tasks
5e558e0
to
05cab6f
Compare
mgol
added a commit
to jquery/jquery
that referenced
this pull request
Mar 31, 2025
Also, fix `mock.php` formatting to not fail the `jQuery.get( String, null, String )` test in PHP mode. Closes gh-5640 Ref gh-4989 Ref jquery/api.jquery.com#1208
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Mar 31, 2025
Also, fix `mock.php` formatting to not fail the `jQuery.get( String, null, String )` test in PHP mode. Ref jquerygh-5640 Ref jquerygh-4989 Ref jquery/api.jquery.com#1208
This was referenced Mar 31, 2025
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Apr 1, 2025
Also, fix `mock.php` formatting to not fail the `jQuery.get( String, null, String )` test in PHP mode. Ref jquerygh-5640 Ref jquerygh-4989 Ref jquery/api.jquery.com#1208
05cab6f
to
3c1c919
Compare
3c1c919
to
eda8b21
Compare
mgol
added a commit
to jquery/jquery
that referenced
this pull request
May 12, 2025
Also, fix `mock.php` formatting to not fail the `jQuery.get( String, null, String )` test in PHP mode. Closes gh-5645 Ref gh-5640 Ref gh-4989 Ref jquery/api.jquery.com#1208
timmywil
approved these changes
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI failure looks unrelated. We may need to address that in a separate PR.
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Closes jquerygh-1208 Ref jquery/jquery#4989 Ref jquery/jquery#5139 Ref jquery/jquery#5640 Ref jquery/jquery#5645 Ref jquery/jquery#5646
06f3bb9
to
25291a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In jQuery 3.x and older, when providing a
null
value forsuccess
you also have to provide thedata
parameter; you can set it toundefined
.Document this restriction of
jQuery.get
&jQuery.post
.Ref jquery/jquery#4989
Ref jquery/jquery#5139