Tests: Fix tests for jQuery.get( String, null-ish, null-ish, String )
#5646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only noticed it post merge when trying to backport the test to |
This was referenced Mar 31, 2025
The original test's `text` variant just repeated the previous test with 3 parameters; the goal was to use 4 ones. This fixes it. Ref jquerygh-5640 Ref jquerygh-5645
mgol
force-pushed
the
jquery-get-test-fix
branch
from
19185c7 to
27288a1
Compare
mgol
added
the
Discuss in Meeting
timmywil
approved these changes
May 12, 2025
timmywil
removed
the
Discuss in Meeting
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
May 12, 2025
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Closes jquerygh-1208 Ref jquery/jquery#4989 Ref jquery/jquery#5139 Ref jquery/jquery#5640 Ref jquery/jquery#5645 Ref jquery/jquery#5646
mgol
added a commit
to jquery/api.jquery.com
that referenced
this pull request
May 12, 2025
In jQuery 3.x and older, when providing a `null` value for `success` you also have to provide the `data` parameter; you can set it to `undefined`. Document this restriction of `jQuery.get` & `jQuery.post`. Closes gh-1208 Ref jquery/jquery#4989 Ref jquery/jquery#5139 Ref jquery/jquery#5640 Ref jquery/jquery#5645 Ref jquery/jquery#5646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original test's
textvariant just repeated the previous test with 3 parameters; the goal was to use 4 ones. This fixes it.Ref gh-5640
Ref gh-5645
Checklist
data: nullwith 3 params api.jquery.com#1208