Hide CancellationToken parameters from CLI help output
#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CLI help output
…tionToken` parameters
lex57ukr
changed the title
CancellationToken parameters from CLI help output
lex57ukr
deleted the
21-hide-cancellationtoken-parameters-from-cli-help-output
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cocona exposes method parameters as CLI options by default, which caused
CancellationTokenparameters to appear as--cancellation-tokenin help output. This PR removes those parameters from command method signatures and instead injectsICoconaAppContextAccessorto access the cancellation token from the Cocona app context. This keeps CLI help clean and user-focused while preserving proper cancellation support.Related Issues
Fixes #21
Changes
SwitchTemplateSubCommandandNewCommandControllerto injectICoconaAppContextAccessorand retrieveCancellationTokenfrom context instead of method parametersCoconaCommandMethodConventionsTestsregression test that scans command methods via reflection and fails if any exposeCancellationTokenparametersCoconaAppContextFactorytest utility for creatingCoconaAppContextinstances in testsCLAUDE.mdwith Cocona conventions for handlingCancellationTokenand document the new test utilities