-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert managedclusters service to SDKv2 #3857
Conversation
/retitle [WIP] Convert managedclusters service to SDKv2 There are still a couple |
dff3b0e
to
6b286b9
Compare
da6b84d
to
02c1f70
Compare
629dcb2
to
7e45647
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3857 +/- ##
==========================================
+ Coverage 55.59% 55.77% +0.18%
==========================================
Files 190 190
Lines 19507 19475 -32
==========================================
+ Hits 10844 10863 +19
+ Misses 8056 8004 -52
- Partials 607 608 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for squash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
/lgtm
/approve
LGTM label has been added. Git tree hash: 054bbe9c9f424f530ac6075b88758a75b60a5882
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts flake |
/hold The AKS is test is taking an unusually long time, so even if it passes I'd like to verify that it's an outlier. |
/retest |
/test pull-cluster-api-provider-azure-e2e-aks Let's see another green run. |
last aks run failed /retest |
/test pull-cluster-api-provider-azure-e2e-aks |
@mboersma I checked the two previous e2e failures, they happened at two different places in the test so I don't think there's a pattern |
/hold cancel |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Converts the managedclusters service and the agentpools service to use SDKv2 and the
asyncpoller
framework for long-running operations.Which issue(s) this PR fixes:
Fixes #3861
Refs #3409
Special notes for your reviewer:
TODOs:
Release note: