Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to default development branch #429

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Update references to default development branch #429

merged 1 commit into from
Sep 20, 2021

Conversation

justaugustus
Copy link
Contributor

@justaugustus justaugustus commented Sep 15, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We're now in the changes post-rename
phase of #424.

I'm opening this PR to first:

  • validate that this repo's presubmits still work as intended, and then:
  • sweep any outstanding doc references

Signed-off-by: Stephen Augustus [email protected]

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. wg/k8s-infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2021
@justaugustus
Copy link
Contributor Author

justaugustus commented Sep 15, 2021 •
edited
Loading

All of the presubmits are happy. Yayyyyyyy!! 🎉
/pony party

@k8s-ci-robot
Copy link
Contributor

@justaugustus: pony image

In response to this:

All the presubmits are happy. Yayyyyyyy!! 🎉
/pony party

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus mentioned this pull request Sep 15, 2021
Closed
28 tasks
@cpanato
Copy link
Member

cpanato commented Sep 16, 2021

/pony party

@k8s-ci-robot
Copy link
Contributor

@cpanato: pony image

In response to this:

/pony party

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Update references to default development branch
272930c 
...and other link fixes.

Signed-off-by: Stephen Augustus <[email protected]>
@justaugustus justaugustus changed the title [WIP] Superfluous commit to validate presubmits pass after renames Update references to default development branch Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 20, 2021
Verolop
Verolop approved these changes Sep 20, 2021
View reviewed changes
Copy link

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, Verolop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9c6e1a1 into kubernetes-sigs:main Sep 20, 2021
@justaugustus justaugustus mentioned this pull request Oct 2, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Verolop Verolop Verolop approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@puerco puerco Awaiting requested review from puerco

Assignees

@Verolop Verolop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justaugustus @k8s-ci-robot @cpanato @Verolop