[scanner] fix: split oversized lib tests - #22784
Conversation
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!
This is an automated message. |
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
3 similar comments
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
Auto Test GeneratorThe following new files have no corresponding test file:
Please add tests or apply the |
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
♿ Accessibility Audit (WCAG 2.1 AA)✅ No WCAG 2.1 AA violations detected in audited routes. Powered by axe-core. Target: WCAG 2.1 AA compliance. |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: All Cards TTFI (Hard Gate), App Visual Regression, Build Frontend, build (linux/amd64, ubuntu-24.04, amd64), build (linux/arm64, ubuntu-24.04-arm, arm64), build-gate, fullstack-smoke Raw failure evidence (from check-run annotations): Remove the |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: All Cards TTFI (Hard Gate), App Visual Regression, Build Frontend, build (linux/amd64, ubuntu-24.04, amd64), build (linux/arm64, ubuntu-24.04-arm, arm64), build-gate, fullstack-smoke Raw failure evidence (from check-run annotations): Remove the |
1 similar comment
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: All Cards TTFI (Hard Gate), App Visual Regression, Build Frontend, build (linux/amd64, ubuntu-24.04, amd64), build (linux/arm64, ubuntu-24.04-arm, arm64), build-gate, fullstack-smoke Raw failure evidence (from check-run annotations): Remove the |
Split 7 oversized test files (>500 lines) into 23 focused test modules: **Issue #22773 — lib tests:** - kubectlProxy.additional.resources (915 → 4 files) - analytics-coverage-tracking (908 → 4 files) - worker.module (867 → 3 files) - kubectlProxy.resources.transform (865 → 3 files) - ModalRuntime-coverage (857 → 3 files) **Issue #22774 — component & context tests:** - DynamicCard (890 → 4 files) - AlertsContext.additional (851 → 2 files) All resulting files are <500 lines. Test coverage maintained. Fixes #22773 Fixes #22774 Signed-off-by: GitHub Copilot <223556219+Copilot@users.noreply.github.com>
138830e to
51396fc
Compare
| import userEvent from '@testing-library/user-event' | ||
| import { Tier1CardRuntime } from '../DynamicCard' | ||
| import type { DynamicCardDefinition } from '../../../lib/dynamic-cards/types' | ||
| import { BTN } from '../../../test-utils/buttonLabels' |
| * new URL() instead of includes() to prevent CodeQL | ||
| * js/incomplete-url-substring-sanitization false positives (#9119). | ||
| */ | ||
| function srcHasHostname(el: Element, hostname: string): boolean { |
| * new URL() instead of includes() to prevent CodeQL | ||
| * js/incomplete-url-substring-sanitization false positives (#9119). | ||
| */ | ||
| function srcHasHostname(el: Element, hostname: string): boolean { |
| @@ -0,0 +1,400 @@ | |||
| import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest' | |||
| // --------------------------------------------------------------------------- | ||
|
|
||
| /** Maximum number of messages to queue while waiting for database init. */ | ||
| const MAX_PENDING_MESSAGES = 1000 |
| } | ||
|
|
||
| // Replicate processMessage for dispatch testing | ||
| function processMessage( |
| import { | ||
| ModalRuntime, | ||
| registerSectionRenderer, | ||
| parseModalYAML, | ||
| } from '../ModalRuntime' |
| * - parseModalYAML throws | ||
| */ | ||
| import { describe, it, expect, vi, beforeEach } from 'vitest' | ||
| import { render, screen, fireEvent } from '@testing-library/react' |
| import { | ||
| ModalRuntime, | ||
| registerSectionRenderer, | ||
| parseModalYAML, | ||
| } from '../ModalRuntime' |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: All Cards TTFI (Hard Gate), App Visual Regression, Build Frontend, build (linux/amd64, ubuntu-24.04, amd64), build (linux/arm64, ubuntu-24.04-arm, arm64), build-gate, fullstack-smoke Raw failure evidence (from check-run annotations): Remove the |
1 similar comment
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: All Cards TTFI (Hard Gate), App Visual Regression, Build Frontend, build (linux/amd64, ubuntu-24.04, amd64), build (linux/arm64, ubuntu-24.04-arm, arm64), build-gate, fullstack-smoke Raw failure evidence (from check-run annotations): Remove the |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate Raw failure evidence (from check-run annotations): Remove the |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Superseded: main already contains equivalent splits of every file this PR touched except DynamicCard.test.tsx — AlertsContext.additional (#22820-era split), analytics-coverage-tracking (#22800), kubectlProxy resources+transform (#22825 et al), worker.module, and ModalRuntime-coverage are all already split on main with identical test counts. The one remaining novel piece, the DynamicCard.test.tsx split, continues in the dedicated PR #22826. Closing to avoid duplicate work. |
Part of #22749
— hive: agent=scanner backend=copilot model=auto