[scanner] fix: split oversized hooks and MCP hook tests - #22800
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!
This is an automated message. |
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), a11y-audit, attribute, build (linux/arm64, ubuntu-24.04-arm, arm64), build-gate Raw failure evidence (from check-run annotations): Remove the |
9f40fee to
b44669c
Compare
♿ Accessibility Audit (WCAG 2.1 AA)✅ No WCAG 2.1 AA violations detected in audited routes. Powered by axe-core. Target: WCAG 2.1 AA compliance. |
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate, pr-check Raw failure evidence (from check-run annotations): Remove the |
1 similar comment
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate, pr-check Raw failure evidence (from check-run annotations): Remove the |
🛑 Fix loop escalated — human attention neededThis PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it. Failing checks: Test (chromium, shard 3), build-gate, pr-check Raw failure evidence (from check-run annotations): Remove the |
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
Remove unused imports, module-level constants, dead helper copies, and unused destructured testable bindings left behind by the test split; underscore-prefix intentionally unused locals; add a targeted no-this-alias disable for the mock socket instance tracker. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Rebased onto main. Dropped the hooks/MCP/kubectlProxy splits already merged via #22815, #22793, and #22814 (main wins); this PR now carries only its novel work: splitting analytics-coverage-tracking.test.ts (908 lines) into tracking/errors/session (all 64 test titles preserved). Note: open PR #22784 also splits analytics-coverage-tracking — whichever merges second will need a rebase. |
136b1f2 to
a047285
Compare
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
* [scanner] fix: split oversized test files (#22770, #22771, #22772, #22773) Signed-off-by: GitHub Copilot <223556219+Copilot@users.noreply.github.com> * 🌱 fix(lint): drop unused imports/vars in split test files Remove unused imports, module-level constants, dead helper copies, and unused destructured testable bindings left behind by the test split; underscore-prefix intentionally unused locals; add a targeted no-this-alias disable for the mock socket instance tracker. Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: GitHub Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: GitHub Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Andrew Anderson <andy@clubanderson.com>
Fixes #22770
Fixes #22771
Fixes #22772
Split 11 oversized test files (>500 lines each) in
src/hooks/__tests__/,src/hooks/, andsrc/hooks/mcp/__tests__/into focused modules, each <500 lines. All existing assertions preserved. No test coverage removed.#22770 — hooks/tests (part 1):
useCachedData.sse-agent.test.ts(919→441) → +.local+.workloadsagentConnectivity.test.tsx(896→497) → +.advanced+.degradeduseCachedISO27001.test.ts(888→353) → +.checks+.networkuseStellar.test.tsx(885→336) → +.actions+.sse-events+.lifecycleuseUpdateProgress.state.test.ts(864→387) → +.backend+.stale#22771 — hooks/ fetchers + missions:
useCachedData.fetchers.advanced.test.ts(856→456) → +.progressive+.keys+.staleuseCachedData.progressive-gpu.gpu.test.ts(851→331) → +.core+.demo+.cluster+.gitops+.cronjobuseMissions-operations.test.tsx(881→410) → +.controls+.load#22772 — mcp/tests:
shared-websocket-detect.test.ts(900→393) → +.health+.merge+.cloudworkloads-coverage.test.ts(874→294) → +.pods-error+.deployments+.statefulsetsworkloadQueries.test.ts(871→452) → +.pods-sse+.issues+.deployments— hive: agent=scanner backend=copilot model=auto copilot=1.0.78