Skip to content

[scanner] fix: split oversized hooks and MCP hook tests - #22800

Merged
kubestellar-hive[bot] merged 2 commits into
mainfrom
scanner/fix-22770-work
Aug 26, 2026
Merged

[scanner] fix: split oversized hooks and MCP hook tests#22800
kubestellar-hive[bot] merged 2 commits into
mainfrom
scanner/fix-22770-work

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Fixes #22770
Fixes #22771
Fixes #22772

Split 11 oversized test files (>500 lines each) in src/hooks/__tests__/, src/hooks/, and src/hooks/mcp/__tests__/ into focused modules, each <500 lines. All existing assertions preserved. No test coverage removed.

#22770 — hooks/tests (part 1):

  • useCachedData.sse-agent.test.ts (919→441) → +.local +.workloads
  • agentConnectivity.test.tsx (896→497) → +.advanced +.degraded
  • useCachedISO27001.test.ts (888→353) → +.checks +.network
  • useStellar.test.tsx (885→336) → +.actions +.sse-events +.lifecycle
  • useUpdateProgress.state.test.ts (864→387) → +.backend +.stale

#22771 — hooks/ fetchers + missions:

  • useCachedData.fetchers.advanced.test.ts (856→456) → +.progressive +.keys +.stale
  • useCachedData.progressive-gpu.gpu.test.ts (851→331) → +.core +.demo +.cluster +.gitops +.cronjob
  • useMissions-operations.test.tsx (881→410) → +.controls +.load

#22772 — mcp/tests:

  • shared-websocket-detect.test.ts (900→393) → +.health +.merge +.cloud
  • workloads-coverage.test.ts (874→294) → +.pods-error +.deployments +.statefulsets
  • workloadQueries.test.ts (871→452) → +.pods-sse +.issues +.deployments

— hive: agent=scanner backend=copilot model=auto copilot=1.0.78

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Aug 25, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Aug 25, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit a047285
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a8f5a0c3ba9af0007ab79f8
😎 Deploy Preview https://deploy-preview-22800.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

Comment thread split_tests.py Fixed
Comment thread split_tests.py Fixed
Comment thread web/src/hooks/__tests__/useCachedData.fetchers.keys.test.ts Fixed
Comment thread web/src/hooks/__tests__/useCachedData.fetchers.progressive.test.ts Fixed
Comment thread web/src/hooks/__tests__/useCachedData.fetchers.stale.test.ts Fixed
Comment thread web/src/hooks/__tests__/useCachedData.progressive-gpu.demo.test.ts Fixed
Comment thread web/src/hooks/__tests__/useCachedData.progressive-gpu.pods.test.ts Fixed
Comment thread web/src/hooks/__tests__/useCachedData.sse-agent.local.test.ts Fixed
Comment thread web/src/hooks/__tests__/useCachedData.sse-agent.workloads.test.ts Fixed
@github-actions

Copy link
Copy Markdown
Contributor

❌ Playwright Tests Failed

📊 View Full Report

Download the playwright-report artifact from the workflow run for screenshots and detailed traces.

To view the report locally:

# Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report

@kubestellar-hive

Copy link
Copy Markdown
Contributor Author

🛑 Fix loop escalated — human attention needed

This PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it.

Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), a11y-audit, attribute, build (linux/arm64, ubuntu-24.04-arm, arm64), build-gate

Raw failure evidence (from check-run annotations):

Test (chromium, shard 2): 3) [chromium] › e2e/enterprise-compliance.spec.ts:73:7 › Enterprise Compliance Portal › Vertical Dashboards › navigates to FedRAMP vertical 
Test (chromium, shard 2): 3) [chromium] › e2e/enterprise-compliance.spec.ts:73:7 › Enterprise Compliance Portal › Vertical Dashboards › navigates to FedRAMP vertical 
Test (chromium, shard 2): 2) [chromium] › e2e/enterprise-compliance.spec.ts:73:7 › Enterprise Compliance Portal › Vertical Dashboards › navigates to NIST 800-53 vertical 
Test (chromium, shard 2): 2) [chromium] › e2e/enterprise-compliance.spec.ts:73:7 › Enterprise Compliance Portal › Vertical Dashboards › navigates to NIST 800-53 vertical 
Test (chromium, shard 2): 2) [chromium] › e2e/enterprise-compliance.spec.ts:73:7 › Enterprise Compliance Portal › Vertical Dashboards › navigates to NIST 800-53 vertical 

Remove the needs-human label after addressing the root cause to return the PR to the automated fix lane.

@kubestellar-hive
kubestellar-hive Bot force-pushed the scanner/fix-22770-work branch from 9f40fee to b44669c Compare August 26, 2026 00:52
@github-actions github-actions Bot added the ai-generated Pull request generated by AI label Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

♿ Accessibility Audit (WCAG 2.1 AA)

✅ No WCAG 2.1 AA violations detected in audited routes.


Powered by axe-core. Target: WCAG 2.1 AA compliance.

@github-actions

Copy link
Copy Markdown
Contributor

❌ Playwright Tests Failed

📊 View Full Report

Download the playwright-report artifact from the workflow run for screenshots and detailed traces.

To view the report locally:

# Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report

@kubestellar-hive

Copy link
Copy Markdown
Contributor Author

🛑 Fix loop escalated — human attention needed

This PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it.

Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate, pr-check

Raw failure evidence (from check-run annotations):

Test (chromium, shard 1): Process completed with exit code 1.
Test (chromium, shard 1): web/[chromium] › e2e/compliance/card-cache-compliance.spec.ts took 5.1m
Test (chromium, shard 1): 1) [chromium] › e2e/compliance/interaction-compliance.spec.ts:388:3 › Interaction Compliance › sidebar collapse/expand 
Test (chromium, shard 1): 1) [chromium] › e2e/compliance/interaction-compliance.spec.ts:388:3 › Interaction Compliance › sidebar collapse/expand 
Test (chromium, shard 3): 1) [chromium] › e2e/perf/dashboard-nav.spec.ts:520:1 › cold-nav — first visit to each dashboard via sidebar 
Test (chromium, shard 3): 1) [chromium] › e2e/perf/dashboard-nav.spec.ts:520:1 › cold-nav — first visit to each dashboard via sidebar 

Remove the needs-human label after addressing the root cause to return the PR to the automated fix lane.

1 similar comment
@kubestellar-hive

Copy link
Copy Markdown
Contributor Author

🛑 Fix loop escalated — human attention needed

This PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it.

Failing checks: Test (chromium, shard 1), Test (chromium, shard 2), Test (chromium, shard 3), build-gate, pr-check

Raw failure evidence (from check-run annotations):

Test (chromium, shard 1): Process completed with exit code 1.
Test (chromium, shard 1): web/[chromium] › e2e/compliance/card-cache-compliance.spec.ts took 5.1m
Test (chromium, shard 1): 1) [chromium] › e2e/compliance/interaction-compliance.spec.ts:388:3 › Interaction Compliance › sidebar collapse/expand 
Test (chromium, shard 1): 1) [chromium] › e2e/compliance/interaction-compliance.spec.ts:388:3 › Interaction Compliance › sidebar collapse/expand 
Test (chromium, shard 3): 1) [chromium] › e2e/perf/dashboard-nav.spec.ts:520:1 › cold-nav — first visit to each dashboard via sidebar 
Test (chromium, shard 3): 1) [chromium] › e2e/perf/dashboard-nav.spec.ts:520:1 › cold-nav — first visit to each dashboard via sidebar 

Remove the needs-human label after addressing the root cause to return the PR to the automated fix lane.

@kubestellar-hive

Copy link
Copy Markdown
Contributor Author

🛑 Fix loop escalated — human attention needed

This PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it.

Failing checks: Test (chromium, shard 3), build-gate, pr-check

Raw failure evidence (from check-run annotations):

Test (chromium, shard 3): Process completed with exit code 1.
Test (chromium, shard 3): 1) [chromium] › e2e/perf/dashboard-nav.spec.ts:521:1 › cold-nav — first visit to each dashboard via sidebar 
Test (chromium, shard 3): 1) [chromium] › e2e/perf/dashboard-nav.spec.ts:521:1 › cold-nav — first visit to each dashboard via sidebar 

Remove the needs-human label after addressing the root cause to return the PR to the automated fix lane.

@github-actions

Copy link
Copy Markdown
Contributor

❌ Playwright Tests Failed

📊 View Full Report

Download the playwright-report artifact from the workflow run for screenshots and detailed traces.

To view the report locally:

# Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report

Copilot AI and others added 2 commits August 26, 2026 17:26
…2773)

Signed-off-by: GitHub Copilot <223556219+Copilot@users.noreply.github.com>
Remove unused imports, module-level constants, dead helper copies, and
unused destructured testable bindings left behind by the test split;
underscore-prefix intentionally unused locals; add a targeted
no-this-alias disable for the mock socket instance tracker.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson

Copy link
Copy Markdown
Collaborator

Rebased onto main. Dropped the hooks/MCP/kubectlProxy splits already merged via #22815, #22793, and #22814 (main wins); this PR now carries only its novel work: splitting analytics-coverage-tracking.test.ts (908 lines) into tracking/errors/session (all 64 test titles preserved). Note: open PR #22784 also splits analytics-coverage-tracking — whichever merges second will need a rebase.

@github-actions

Copy link
Copy Markdown
Contributor

❌ Playwright Tests Failed

📊 View Full Report

Download the playwright-report artifact from the workflow run for screenshots and detailed traces.

To view the report locally:

# Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report

@kubestellar-hive
kubestellar-hive Bot merged commit 0daeb1e into main Aug 26, 2026
34 of 40 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-22770-work branch August 26, 2026 22:03
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions

Copy link
Copy Markdown
Contributor

Post-merge build verification passed

Both Go and frontend builds compiled successfully against merge commit 0daeb1e2d447b341dfb3688aeb04d7597a4777fc.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Post-Merge Verification: passed

Commit: 0daeb1e2d447b341dfb3688aeb04d7597a4777fc
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/33018039489

kubestellar-hive Bot added a commit that referenced this pull request Aug 27, 2026
* [scanner] fix: split oversized test files (#22770, #22771, #22772, #22773)

Signed-off-by: GitHub Copilot <223556219+Copilot@users.noreply.github.com>

* 🌱 fix(lint): drop unused imports/vars in split test files

Remove unused imports, module-level constants, dead helper copies, and
unused destructured testable bindings left behind by the test split;
underscore-prefix intentionally unused locals; add a targeted
no-this-alias disable for the mock socket instance tracker.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

---------

Signed-off-by: GitHub Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: GitHub Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI dco-signoff: yes Indicates the PR's author has signed the DCO. needs-human size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tier/1-lightweight

Projects

None yet

2 participants