This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Match fix #392
Closed
Match fix #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commits are separated. I'll make the docstrings and tests tomorrow. |
from argument treatment (work_or_pass) It implements work_or_pass for GenericStruct and GenericType and make derivatives (like TypeList) use original pack/get_size funcs. This makes possible to implement _pack/_get_size and leave argument treatment and docstring to original GenericType/GenericStruct pack/get_size method include _ for customTLV and typeList pack and get_size funcs
Closed
|
[UPDATE: I have included a commit to fix ActionSetField], see first comment. |
This was referenced Jul 24, 2017
This was referenced Jun 7, 2021
Open
This was referenced Jun 28, 2021
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #348.
It implements
Match,MatchFields,OxmTLVandCustomTLVclasses for use inPACKETINs.The other structures affected in the issue (like
ActionSetFieldfor example) have not yet been treated. [UPDATE: I have included a commit to fix ActionSetField]I'll still organize the commits, remove comments, update the docstrings, and organize a few tests I've made to include in the testing suite.
Please for now include comments in the PR comments tread since these commits will probably be overwritten by amended ones.
This was tested unpacking a packet-in described in the email reporting a packet-in unpack exception:
——————— Packet In ————————— —
Transmission Control Protocol, Src Port: 55566, Dst Port: 6633, Seq:
172, Ack: 25, Len: 123
OpenFlow 1.3
Version: 1.3 (0x04)
Type: OFPT_PACKET_IN (10)
Length: 123
Transaction ID: 0
Buffer ID: 257
Total length: 81
Reason: OFPR_ACTION (1)
Table ID: 0
Cookie: 0xffffffffffffffff
Match
Type: OFPMT_OXM (1)
Length: 12
OXM field
Class: OFPXMC_OPENFLOW_BASIC (0x8000)
0000 000. = Field: OFPXMT_OFB_IN_PORT (0)
.... ...0 = Has mask: False
Length: 4
Value: 22
Pad: 00000000
Pad: 0000
Data