-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FR-360): add max_pending_session_count
, max_concurrent_sftp_sessions
to keypair resource policy.
#3025
base: main
Are you sure you want to change the base?
feat(FR-360): add max_pending_session_count
, max_concurrent_sftp_sessions
to keypair resource policy.
#3025
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 4.66% (-0.03% 🔻) |
398/8546 |
🔴 | Branches | 4.04% (-0.02% 🔻) |
239/5922 |
🔴 | Functions | 2.83% (-0.01% 🔻) |
78/2752 |
🔴 | Lines | 4.58% (-0.03% 🔻) |
383/8363 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from f8d3a24
27be261
to
b8ee0c8
Compare
9ce0490
to
0214a36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On create/modify of keypair resource policy, the value of the resource part is not saved. It is always fixed to unlimited.
0214a36
to
b0b032a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve conflicts :)
…essions` to keypair resource policy.
b0b032a
to
f8d3a24
Compare
all resolved. thank you for feedbacks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When creating a new keypair resource policy, the value of max_concurrent_sftp_sessions follows the value of Concurrent Jobs.
e.g. ) If you create a value of 3 for concurrent jobs, the value of sftp sessions is unconditionally created as 3.
resolves #3017
related PR: https://lablup.atlassian.net/browse/FR-317
refer: lablup/backend.ai#3413
Added support for two new resource policy fields in keypair resource policy:
max_pending_session_count
: Controls maximum number of sessions that can be in pending statemax_concurrent_sftp_sessions
: Controls maximum number of concurrent SFTP sessionsChecklist:
The PR also includes:
Screenshots:

