Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-367): add keypair resource policy info modal #3030

Open
wants to merge 1 commit into
base: feature/support-new-2403-fields-to-keypair-resource-policy
Choose a base branch
from

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Jan 14, 2025

resolves (FR-367)

Adds a new modal component to display allowed vfolder host permissions and enhances the resource policy information display. The modal shows detailed permission status for each storage host with visual indicators (checkmarks/stops) for allowed/disallowed permissions.

Key changes:

  • New AllowedVfolderHostsWithPermissionModal component for displaying storage host permissions
  • Enhanced KeypairResourcePolicyInfoModal with detailed resource policy information
  • Added translations for new permission-related strings
  • Added support for max pending session resource slots feature flag

Checklist:

  • Documentation
  • Minium required manager version: 24.03.4
  • Test case: Check permission display for storage hosts with varying levels of access (full/partial/no permissions)

Screenshots:
image.png

Copy link
Contributor Author

agatha197 commented Jan 14, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 force-pushed the feature/support-new-2403-fields-to-keypair-resource-policy branch from b8ee0c8 to 9ce0490 Compare February 5, 2025 07:03
@agatha197 agatha197 force-pushed the feature/add-keypair-info-modal branch from c4ba20a to da7d8d9 Compare February 5, 2025 07:04
@agatha197 agatha197 force-pushed the feature/support-new-2403-fields-to-keypair-resource-policy branch from 9ce0490 to 0214a36 Compare February 5, 2025 07:13
@agatha197 agatha197 force-pushed the feature/add-keypair-info-modal branch from da7d8d9 to 806ce68 Compare February 5, 2025 07:13
@agatha197 agatha197 force-pushed the feature/support-new-2403-fields-to-keypair-resource-policy branch from 0214a36 to b0b032a Compare February 7, 2025 05:57
@agatha197 agatha197 force-pushed the feature/add-keypair-info-modal branch 2 times, most recently from ef8debd to 329a92d Compare February 7, 2025 05:59
@agatha197 agatha197 requested a review from ironAiken2 February 7, 2025 05:59
@agatha197 agatha197 force-pushed the feature/support-new-2403-fields-to-keypair-resource-policy branch from b0b032a to f8d3a24 Compare February 10, 2025 04:16
@agatha197 agatha197 force-pushed the feature/add-keypair-info-modal branch from 329a92d to 4a8a872 Compare February 10, 2025 04:17
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values don't match exactly.

image.png

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants