Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(FR-457): clean up unused configuration of config.toml #3325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Mar 10, 2025

resolves #3090 (FR-457)

Removes unused configuration options and UI elements:
You can check detail information about deleted configurations in loop component

  • Removed siteDescription from config.toml
  • Removed enableModelStore and enableLLMPlayground flags
  • Removed logo title related properties from theme configuration
  • Removed model store tab from VFolder list page
  • Updated project selection to use blocklist for model store access
  • Added blocklist check for chat feature in endpoint details

Checklist:

  • Documentation
  • Minium required manager version
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:M 30~100 LoC label Mar 10, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Coverage report for ./react

Action wasn't able to generate report within GitHub comment limit. If you're facing this issue, please let me know by commenting under this issue.

Report generated by 🧪jest coverage report action from ebc36dd

@ironAiken2 ironAiken2 force-pushed the chore/clean-up-config-toml-file branch from ebc36dd to 4b1c84b Compare March 10, 2025 07:56
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Mar 10, 2025
@ironAiken2 ironAiken2 changed the title chore: clean up unused configuration of config.toml chore(FR-457): clean up unused configuration of config.toml Mar 10, 2025
@ironAiken2 ironAiken2 marked this pull request as ready for review March 10, 2025 07:59
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

siteDescription is also never used. Some files still have siteDescription. Let's find it in all files and please remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up unused configuration of config.toml
2 participants