refactor(l2): use hardcoded vk in Aligned mode #3175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
avilagaston9
changed the base branch from
main
to
l2/fix/use_aligned_sdk_release
…d_use_hardcoded_vk
…d_use_hardcoded_vk
…d_use_hardcoded_vk
avilagaston9
requested review from
a team,
ManuelBilbao and
jrchatruc
as code owners
iovoid
reviewed
Jun 24, 2025
docs/l2/aligned_mode.md
Outdated
| > Save the addresses of the deployed proxy contracts, as you will need them to run the L2 node. | ||
| ### 2. Deposit funds to the `AlignedBatchePaymentService` contract from the proof sender | ||
| ### 3. Deposit funds to the `AlignedBatchePaymentService` contract from the proof sender |
There was a problem hiding this comment.
Do you mean AlignedBatcherPaymentService?
There was a problem hiding this comment.
Fixed 397e0c7!
|
|
||
| if aligned_mode == "true" { | ||
| let vk = vk.vk.hash_bytes(); | ||
| dbg!(&vk); |
There was a problem hiding this comment.
Should be removed or replaced with a print.
There was a problem hiding this comment.
Removed 39425e1!
ilitteri
reviewed
Jun 24, 2025
Co-authored-by: Ivan Litteri <[email protected]>
ilitteri
approved these changes
Jun 24, 2025
iovoid
approved these changes
Jun 24, 2025
ManuelBilbao
approved these changes
Jun 24, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** We are passing the verification key every time we call `verifyBatchAligned()`. **Description** - Initializes `SP1_VERIFICATION_KEY` in the `OnChainProposer` contract with the Aligned vk and reuses it in `verifyBatchAligned()`. - Since `l1_proof_verifier` needs the vk for `aligned_sdk:check_proof_verification()`, it retrieves it from the contract as well. Closes lambdaclass#3030 --------- Co-authored-by: Ivan Litteri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are passing the verification key every time we call
verifyBatchAligned().Description
SP1_VERIFICATION_KEYin theOnChainProposercontract with the Aligned vk and reuses it inverifyBatchAligned().l1_proof_verifierneeds the vk foraligned_sdk:check_proof_verification(), it retrieves it from the contract as well.Closes #3030