Skip to content

Conversation

@Jay-ju
Copy link
Contributor

@Jay-ju Jay-ju commented Oct 10, 2025

No description provided.

@Jay-ju Jay-ju marked this pull request as draft October 10, 2025 08:05
@github-actions github-actions bot added enhancement New feature or request python labels Oct 10, 2025
@Jay-ju Jay-ju force-pushed the approx-count branch 2 times, most recently from 844d4f8 to b70c0ff Compare October 10, 2025 09:01
@Jay-ju
Copy link
Contributor Author

Jay-ju commented Oct 10, 2025

@jackye1995
This PR is based on #4735 and #4805 Regarding the discussion content, first provide an approximate line count and add some benchmark tests. It seems that the efficiency of the approximate calculation is still very high.
image

@Jay-ju Jay-ju force-pushed the approx-count branch 13 times, most recently from 3b97c49 to e03d7f8 Compare October 11, 2025 02:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2025

Codecov Report

❌ Patch coverage is 72.64151% with 116 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.73%. Comparing base (a3ed68d) to head (413cee1).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/dataset/fragment/approx.rs 71.42% 45 Missing and 7 partials ⚠️
rust/lance-index/src/scalar/expression.rs 77.77% 37 Missing and 3 partials ⚠️
rust/lance-index/src/scalar/zonemap.rs 32.14% 18 Missing and 1 partial ⚠️
rust/lance/src/dataset/scanner.rs 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4930      +/-   ##
==========================================
+ Coverage   81.64%   81.73%   +0.08%     
==========================================
  Files         333      335       +2     
  Lines      131594   132843    +1249     
  Branches   131594   132843    +1249     
==========================================
+ Hits       107444   108581    +1137     
- Misses      20550    20613      +63     
- Partials     3600     3649      +49     
Flag Coverage Δ
unittests 81.73% <72.64%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jay-ju Jay-ju marked this pull request as ready for review October 11, 2025 05:41
@Jay-ju
Copy link
Contributor Author

Jay-ju commented Oct 25, 2025

@jackye1995 Please take a look at this PR when you have time.

@jackye1995 jackye1995 self-requested a review October 25, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants