Skip to content

langchain: use mypy strict checking with exemptions #31018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

langchain: use mypy strict checking with exemptions #31018

merged 2 commits into from
May 15, 2025
+69 −60

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Apr 25, 2025 •
edited
Loading

  • Use strict checking and exclude some rules as TODOs
  • Fix imports not exposed in __all__

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview May 15, 2025 3:35pm

@dosubot dosubot bot added size:L labels Apr 25, 2025
@dosubot dosubot bot added the lgtm label May 15, 2025
@eyurtsev eyurtsev self-assigned this May 15, 2025
@eyurtsev eyurtsev merged commit 6cd1aad into langchain-ai:master May 15, 2025
19 checks passed
@cbornet cbornet deleted the langchain-mypy branch May 16, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees

@eyurtsev eyurtsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbornet @eyurtsev