Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add install a package to improve the accuracy of guessing mime type and file extension (plugins/beta) #13101

Closed
wants to merge 1 commit into from

Conversation

kurokobo
Copy link
Contributor

@kurokobo kurokobo commented Jan 28, 2025

Summary

This is for plugins/beta branch.

This PR installs media-types package to improve the accuracy of guessing mime type and file extension.
When creating a file in the tool plugin, we can specify the mime type for the file, but due to the lack of media-types package, even if we provide the correct mime type, the file extension may become .bin in some cases.

Closes #13717

The same PR for main branch: #13752

Screenshots

Before
Without media-types, mimetypes module in Python cannot guess the extension for the specific mime types:
image

After
By installing media-types package, the extension for the specific mime types can be guessed:
image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Jan 28, 2025
@kurokobo
Copy link
Contributor Author

The lint error is for models/dataset.py which is not related to this PR.

@crazywoola crazywoola requested a review from laipz8200 February 14, 2025 04:48
@kurokobo kurokobo changed the title fix: add install a package to improve the accuracy of guessing mime type and file extension fix: add install a package to improve the accuracy of guessing mime type and file extension (plugins/beta) Feb 14, 2025
@kurokobo
Copy link
Contributor Author

This issue affects both main and plugins/beta branches.
I know that regardless of which branch this change is merged into, it will eventually be included in 1.0.0, but I wasn't sure which branch should take priority, so I created a PR for both branches:

It's okay to adopt just one of these PRs. Thanks!

@Yeuoly Yeuoly deleted the branch langgenius:plugins/beta February 17, 2025 09:05
@Yeuoly Yeuoly closed this Feb 17, 2025
@kurokobo kurokobo deleted the mime-support branch February 17, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants