Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add install a package to improve the accuracy of guessing mime type and file extension (main) #13752

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

kurokobo
Copy link
Contributor

Summary

This is for main branch.

This PR installs media-types package to improve the accuracy of guessing mime type and file extension.
When creating a file in the tool plugin, we can specify the mime type for the file, but due to the lack of media-types package, even if we provide the correct mime type, the file extension may become .bin in some cases.

Closes #13717

The same PR for plugins/beta branch: #13101

Screenshots

Before
Without media-types, mimetypes module in Python cannot guess the extension for the specific mime types:
image

After
By installing media-types package, the extension for the specific mime types can be guessed:
image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 14, 2025
@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Feb 14, 2025
@kurokobo
Copy link
Contributor Author

This issue affects both main and plugins/beta branches.
I know that regardless of which branch this change is merged into, it will eventually be included in 1.0.0, but I wasn't sure which branch should take priority, so I created a PR for both branches:

It's okay to adopt just one of these PRs. Thanks!

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 15, 2025
@crazywoola crazywoola merged commit 035e54b into langgenius:main Feb 16, 2025
10 checks passed
@kurokobo kurokobo deleted the mime-support-main branch February 16, 2025 13:46
chinnsenn pushed a commit to chinnsenn/dify that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: mimetypes Module Fails to Detect MIME Types in Minimal Docker Images
3 participants