gpu: Refactor Vulkan device enumeration, lower priority for Dozen #14404
+106
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slime73
reviewed
Nov 6, 2025
Collaborator
|
This approach seems generally fine to me. |
This allows us to treat Dozen as an "other" driver, rather than blacklisting it outright.
flibitijibibo
force-pushed
the
vk_msft
branch
from
0b15ff3 to
82a3737
Compare
flibitijibibo
requested review from
slime73 and
thatcosmonaut
and removed request for
slime73
Collaborator
Author
|
Dunno why it removed the review request, so will say reviews from both would be very appreciated! The latest push also clarifies what actually goes into a device ranking, and should help isolate any future work needed to refine the ranking system. |
This prevents devices without presentation/graphics support from getting ranked.
…lkan devices. This makes it a bit clearer what the "minimum" is vs. the "best", which should be two separate queries.
flibitijibibo
changed the title
This block was a sloppy way of trying to avoid prioritizing lavapipe over another device, but truthfully the only way to guarantee avoiding CPU drivers is to add a property to allow apps to require hardware acceleration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grossly untested!
Fixes #14392