[CIR] Added support for __builtin_ia32_psrldqi_byteshift
#1886
+220
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wizardengineer
commented
Sep 3, 2025
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
lanza
force-pushed
the
main
branch
2 times, most recently
from
8acaf96 to
58135ea
Compare
wizardengineer
force-pushed
the
julius/psrldqi-support
branch
from
ff9f528 to
d00a8cd
Compare
wizardengineer
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
AmrDeveloper
requested changes
Oct 29, 2025
| static mlir::Value emitX86PSRLDQIByteShift(CIRGenFunction &cgf, | ||
| const CallExpr *E, | ||
| ArrayRef<mlir::Value> Ops) { | ||
| auto &builder = cgf.getBuilder(); |
There was a problem hiding this comment.
Please use the type explicitly here, not auto
https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable
| ArrayRef<mlir::Value> Ops) { | ||
| auto &builder = cgf.getBuilder(); | ||
| auto resultType = cast<cir::VectorType>(Ops[0].getType()); | ||
| auto loc = cgf.getLoc(E->getExprLoc()); |
There was a problem hiding this comment.
Please use the type explicitly here, not auto
Suggested change
| auto loc = cgf.getLoc(E->getExprLoc()); | |
| mlir::Location loc = cgf.getLoc(E->getExprLoc()); |
| if (shiftVal >= 16) | ||
| return builder.getZero(loc, resultType); | ||
|
|
||
| auto numElts = resultType.getSize() * 8; |
There was a problem hiding this comment.
Please use the type explicitly here, not auto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #1885