Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc] Don't manually override the optimization level for math #126322

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[libc] Don't manually override the optimization level for math #126322

wants to merge 3 commits into from
+0 −804

Conversation

petrhosek
Copy link
Member

This was originally done for testing purposes, but after #126315 we now do testing through GitHub Actions and should be instead using the optimization setting chosen by the user.

@petrhosek
[libc] Don't manually override the optimization level for math
e2cd8d9 
This was originally done for testing purposes, but after llvm#126315 we
now do testing through GitHub Actions and should be instead using
the optimization setting chosen by the user.
@petrhosek petrhosek added the libc label Feb 7, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 7, 2025

@llvm/pr-subscribers-libc

Author: Petr Hosek (petrhosek)

Changes

This was originally done for testing purposes, but after #126315 we now do testing through GitHub Actions and should be instead using the optimization setting chosen by the user.

Patch is 86.42 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/126322.diff

3 Files Affected:

  • (modified) libc/src/complex/generic/CMakeLists.txt (-64)
  • (modified) libc/src/math/generic/CMakeLists.txt (+1-773)
  • (modified) libc/src/stdfix/CMakeLists.txt (-14)
diff --git a/libc/src/complex/generic/CMakeLists.txt b/libc/src/complex/generic/CMakeLists.txt
index 82d2b01d534a9b8..90acc596275a397 100644
--- a/libc/src/complex/generic/CMakeLists.txt
+++ b/libc/src/complex/generic/CMakeLists.txt
@@ -4,8 +4,6 @@ add_entrypoint_object(
     cproj.cpp
   HDRS
     ../cproj.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.complex_basic_ops
 )
@@ -16,8 +14,6 @@ add_entrypoint_object(
     cprojf.cpp
   HDRS
     ../cprojf.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.complex_basic_ops
 )
@@ -28,8 +24,6 @@ add_entrypoint_object(
     cprojl.cpp
   HDRS
     ../cprojl.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.complex_basic_ops
 )
@@ -40,8 +34,6 @@ add_entrypoint_object(
     cprojf16.cpp
   HDRS
     ../cprojf16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.complex_basic_ops
     libc.src.__support.macros.properties.types
@@ -54,8 +46,6 @@ add_entrypoint_object(
     cprojf128.cpp
   HDRS
     ../cprojf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.complex_basic_ops
     libc.src.__support.macros.properties.types
@@ -68,8 +58,6 @@ add_entrypoint_object(
     conj.cpp
   HDRS
     ../conj.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.complex_basic_ops
 )
@@ -80,8 +68,6 @@ add_entrypoint_object(
     conjf.cpp
   HDRS
     ../conjf.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.complex_basic_ops
 )
@@ -92,8 +78,6 @@ add_entrypoint_object(
     conjl.cpp
   HDRS
     ../conjl.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.complex_basic_ops
 )
@@ -104,8 +88,6 @@ add_entrypoint_object(
     conjf16.cpp
   HDRS
     ../conjf16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.complex_basic_ops
     libc.src.__support.macros.properties.types
@@ -118,8 +100,6 @@ add_entrypoint_object(
     conjf128.cpp
   HDRS
     ../conjf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.complex_basic_ops
     libc.src.__support.macros.properties.types
@@ -132,8 +112,6 @@ add_entrypoint_object(
     creal.cpp
   HDRS
     ../creal.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.CPP.bit
     libc.src.__support.complex_type
@@ -145,8 +123,6 @@ add_entrypoint_object(
     crealf.cpp
   HDRS
     ../crealf.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.CPP.bit
     libc.src.__support.complex_type
@@ -158,8 +134,6 @@ add_entrypoint_object(
     creall.cpp
   HDRS
     ../creall.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.CPP.bit
     libc.src.__support.complex_type
@@ -171,23 +145,6 @@ add_entrypoint_object(
     crealf16.cpp
   HDRS
     ../crealf16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
-  DEPENDS
-    libc.src.__support.CPP.bit
-    libc.src.__support.complex_type
-    libc.src.__support.macros.properties.types
-    libc.src.__support.macros.properties.complex_types
-)
-
-add_entrypoint_object(
-  crealf128
-  SRCS
-    crealf128.cpp
-  HDRS
-    ../crealf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.CPP.bit
     libc.src.__support.complex_type
@@ -201,8 +158,6 @@ add_entrypoint_object(
     cimag.cpp
   HDRS
     ../cimag.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.CPP.bit
     libc.src.__support.complex_type
@@ -214,8 +169,6 @@ add_entrypoint_object(
     cimagf.cpp
   HDRS
     ../cimagf.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.CPP.bit
     libc.src.__support.complex_type
@@ -227,21 +180,6 @@ add_entrypoint_object(
     cimagl.cpp
   HDRS
     ../cimagl.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
-  DEPENDS
-    libc.src.__support.CPP.bit
-    libc.src.__support.complex_type
-)
-
-add_entrypoint_object(
-  cimagf16
-  SRCS
-    cimagf16.cpp
-  HDRS
-    ../cimagf16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.CPP.bit
     libc.src.__support.complex_type
@@ -255,8 +193,6 @@ add_entrypoint_object(
     cimagf128.cpp
   HDRS
     ../cimagf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.CPP.bit
     libc.src.__support.complex_type
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 0e57051807b3327..c61cdc0a3891da9 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -6,8 +6,6 @@ add_entrypoint_object(
     canonicalize.cpp
   HDRS
     ../canonicalize.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.basic_operations
 )
@@ -18,8 +16,6 @@ add_entrypoint_object(
     canonicalizef.cpp
   HDRS
     ../canonicalizef.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.basic_operations
 )
@@ -30,8 +26,6 @@ add_entrypoint_object(
     canonicalizef16.cpp
   HDRS
     ../canonicalizef16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.basic_operations
@@ -43,8 +37,6 @@ add_entrypoint_object(
     canonicalizef128.cpp
   HDRS
     ../canonicalizef128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.basic_operations
@@ -56,8 +48,6 @@ add_entrypoint_object(
     canonicalizel.cpp
   HDRS
     ../canonicalizel.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.basic_operations
 )
@@ -68,8 +58,6 @@ add_entrypoint_object(
     iscanonical.cpp
   HDRS
     ../iscanonical.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -78,8 +66,6 @@ add_entrypoint_object(
     iscanonicalf.cpp
   HDRS
     ../iscanonicalf.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -88,8 +74,6 @@ add_entrypoint_object(
     iscanonicall.cpp
   HDRS
     ../iscanonicall.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -98,8 +82,6 @@ add_entrypoint_object(
     iscanonicalf16.cpp
   HDRS
     ../iscanonicalf16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
 )
@@ -110,8 +92,6 @@ add_entrypoint_object(
     iscanonicalf128.cpp
   HDRS
     ../iscanonicalf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
 )
@@ -122,8 +102,6 @@ add_entrypoint_object(
     ceil.cpp
   HDRS
     ../ceil.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
   FLAGS
@@ -136,8 +114,6 @@ add_entrypoint_object(
     ceilf.cpp
   HDRS
     ../ceilf.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
   FLAGS
@@ -150,8 +126,6 @@ add_entrypoint_object(
     ceill.cpp
   HDRS
     ../ceill.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
 )
@@ -162,8 +136,6 @@ add_entrypoint_object(
     ceilf16.cpp
   HDRS
     ../ceilf16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.cast
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -179,8 +151,6 @@ add_entrypoint_object(
     ceilf128.cpp
   HDRS
     ../ceilf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -192,8 +162,6 @@ add_entrypoint_object(
     daddl.cpp
   HDRS
     ../daddl.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.generic.add_sub
 )
@@ -204,8 +172,6 @@ add_entrypoint_object(
     daddf128.cpp
   HDRS
     ../daddf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
  DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.generic.add_sub
@@ -217,8 +183,6 @@ add_entrypoint_object(
     ddivl.cpp
   HDRS
     ../ddivl.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.generic.div
 )
@@ -229,8 +193,6 @@ add_entrypoint_object(
     ddivf128.cpp
   HDRS
     ../ddivf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.generic.div
@@ -245,8 +207,6 @@ add_entrypoint_object(
   DEPENDS
     libc.src.__support.FPUtil.fma
     libc.src.__support.macros.properties.types
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -257,8 +217,6 @@ add_entrypoint_object(
     ../dfmal.h
   DEPENDS
     libc.src.__support.FPUtil.fma
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -269,8 +227,6 @@ add_entrypoint_object(
     ../dsqrtl.h
   DEPENDS
     libc.src.__support.FPUtil.generic.sqrt
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -282,8 +238,6 @@ add_entrypoint_object(
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.generic.sqrt
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 
@@ -296,8 +250,6 @@ add_entrypoint_object(
   DEPENDS
     libc.src.__support.FPUtil.generic.add_sub
     libc.src.__support.macros.properties.types
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -308,8 +260,6 @@ add_entrypoint_object(
     ../dsubl.h
   DEPENDS
     libc.src.__support.FPUtil.generic.add_sub
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_header_library(
@@ -392,8 +342,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.fenv_impl
     libc.src.__support.FPUtil.fp_bits
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -413,8 +361,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.multiply_add
     libc.src.__support.FPUtil.polyeval
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -449,8 +395,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.fma
     libc.src.__support.FPUtil.multiply_add
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -468,8 +412,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.fp_bits
     libc.src.__support.FPUtil.multiply_add
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -490,8 +432,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.multiply_add
     libc.src.__support.FPUtil.rounding_mode
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -512,8 +452,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.polyeval
     libc.src.__support.FPUtil.rounding_mode
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -555,8 +493,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.fp_bits
     libc.src.__support.FPUtil.multiply_add
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -574,8 +510,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.polyeval
     libc.src.__support.common
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -595,8 +529,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.polyeval
     libc.src.__support.FPUtil.rounding_mode
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -614,8 +546,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.fp_bits
     libc.src.__support.FPUtil.multiply_add
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -635,8 +565,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.fp_bits
     libc.src.__support.FPUtil.multiply_add
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -657,8 +585,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.multiply_add
     libc.src.__support.FPUtil.polyeval
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -696,8 +622,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.except_value_utils
     libc.src.__support.FPUtil.multiply_add
     libc.src.__support.macros.optimization
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -708,8 +632,6 @@ add_entrypoint_object(
     ../fabs.h
   DEPENDS
     libc.src.__support.FPUtil.basic_operations
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   FLAGS
     MISC_MATH_BASIC_OPS_OPT
 )
@@ -722,8 +644,6 @@ add_entrypoint_object(
     ../fabsf.h
   DEPENDS
     libc.src.__support.FPUtil.basic_operations
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   FLAGS
     MISC_MATH_BASIC_OPS_OPT
 )
@@ -736,8 +656,6 @@ add_entrypoint_object(
     ../fabsl.h
   DEPENDS
     libc.src.__support.FPUtil.basic_operations
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -751,8 +669,6 @@ add_entrypoint_object(
     libc.src.__support.FPUtil.basic_operations
     libc.src.__support.macros.properties.architectures
     libc.src.__support.macros.properties.compiler
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   FLAGS
     MISC_MATH_BASIC_OPS_OPT
 )
@@ -766,8 +682,6 @@ add_entrypoint_object(
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.basic_operations
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -778,8 +692,6 @@ add_entrypoint_object(
     ../fadd.h
   DEPENDS
     libc.src.__support.FPUtil.generic.add_sub
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -790,8 +702,6 @@ add_entrypoint_object(
     ../faddl.h
   DEPENDS
     libc.src.__support.FPUtil.generic.add_sub
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -803,8 +713,6 @@ add_entrypoint_object(
   DEPENDS
     libc.src.__support.FPUtil.generic.add_sub
     libc.src.__support.macros.properties.types
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
 )
 
 add_entrypoint_object(
@@ -813,8 +721,6 @@ add_entrypoint_object(
     trunc.cpp
   HDRS
     ../trunc.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
   FLAGS
@@ -827,8 +733,6 @@ add_entrypoint_object(
     truncf.cpp
   HDRS
     ../truncf.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
   FLAGS
@@ -841,8 +745,6 @@ add_entrypoint_object(
     truncl.cpp
   HDRS
     ../truncl.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
 )
@@ -853,8 +755,6 @@ add_entrypoint_object(
     truncf16.cpp
   HDRS
     ../truncf16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.cast
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -870,8 +770,6 @@ add_entrypoint_object(
     truncf128.cpp
   HDRS
     ../truncf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -883,8 +781,6 @@ add_entrypoint_object(
     floor.cpp
   HDRS
     ../floor.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
   FLAGS
@@ -897,8 +793,6 @@ add_entrypoint_object(
     floorf.cpp
   HDRS
     ../floorf.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
   FLAGS
@@ -911,8 +805,6 @@ add_entrypoint_object(
     floorl.cpp
   HDRS
     ../floorl.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
 )
@@ -923,8 +815,6 @@ add_entrypoint_object(
     floorf16.cpp
   HDRS
     ../floorf16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.cast
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -940,8 +830,6 @@ add_entrypoint_object(
     floorf128.cpp
   HDRS
     ../floorf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -953,8 +841,6 @@ add_entrypoint_object(
     round.cpp
   HDRS
     ../round.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
   FLAGS
@@ -967,8 +853,6 @@ add_entrypoint_object(
     roundf.cpp
   HDRS
     ../roundf.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
   FLAGS
@@ -981,8 +865,6 @@ add_entrypoint_object(
     roundl.cpp
   HDRS
     ../roundl.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
 )
@@ -993,8 +875,6 @@ add_entrypoint_object(
     roundf16.cpp
   HDRS
     ../roundf16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.cast
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -1010,8 +890,6 @@ add_entrypoint_object(
     roundf128.cpp
   HDRS
     ../roundf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -1023,8 +901,6 @@ add_entrypoint_object(
     roundeven.cpp
   HDRS
     ../roundeven.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
   FLAGS
@@ -1037,8 +913,6 @@ add_entrypoint_object(
     roundevenf.cpp
   HDRS
     ../roundevenf.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
   FLAGS
@@ -1051,20 +925,6 @@ add_entrypoint_object(
     roundevenl.cpp
   HDRS
     ../roundevenl.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
-  DEPENDS
-    libc.src.__support.FPUtil.nearest_integer_operations
-)
-
-add_entrypoint_object(
-  roundevenf16
-  SRCS
-    roundevenf16.cpp
-  HDRS
-    ../roundevenf16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -1080,8 +940,6 @@ add_entrypoint_object(
     roundevenf128.cpp
   HDRS
     ../roundevenf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -1093,8 +951,6 @@ add_entrypoint_object(
     lround.cpp
   HDRS
     ../lround.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
 )
@@ -1105,8 +961,6 @@ add_entrypoint_object(
     lroundf.cpp
   HDRS
     ../lroundf.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
 )
@@ -1117,8 +971,6 @@ add_entrypoint_object(
     lroundl.cpp
   HDRS
     ../lroundl.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.FPUtil.nearest_integer_operations
 )
@@ -1129,8 +981,6 @@ add_entrypoint_object(
     lroundf16.cpp
   HDRS
     ../lroundf16.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -1142,8 +992,6 @@ add_entrypoint_object(
     lroundf128.cpp
   HDRS
     ../lroundf128.h
-  COMPILE_OPTIONS
-    ${libc_opt_high_flag}
   DEPENDS
     libc.src.__support.macros.properties.types
     libc.src.__support.FPUtil.nearest_integer_operations
@@ -1155,8 +1003,6 @@ add_entrypoint_object(
     llround.c...
[truncated]

nickdesaulniers
nickdesaulniers approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@nickdesaulniers nickdesaulniers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for an ack from @lntue before merging. Tue is offline today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdesaulniers nickdesaulniers nickdesaulniers approved these changes

@lntue lntue Awaiting requested review from lntue

Assignees
No one assigned
Labels
libc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petrhosek @llvmbot @nickdesaulniers