Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Clang][CMake][MSVC] Install PDBs alongside executables" #126934

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

mayanez
Copy link
Contributor

@mayanez mayanez commented Feb 12, 2025

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Feb 12, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 12, 2025

@llvm/pr-subscribers-clang

Author: Miguel A. Arroyo (mayanez)

Changes

Reverts llvm/llvm-project#126675

Broke the following: https://lab.llvm.org/buildbot/#/builders/107/builds/7929


Full diff: https://github.com/llvm/llvm-project/pull/126934.diff

1 Files Affected:

  • (modified) clang/cmake/modules/AddClang.cmake (-4)
diff --git a/clang/cmake/modules/AddClang.cmake b/clang/cmake/modules/AddClang.cmake
index 02f26b6d861ad..cdc8bd5cd503b 100644
--- a/clang/cmake/modules/AddClang.cmake
+++ b/clang/cmake/modules/AddClang.cmake
@@ -138,10 +138,6 @@ macro(add_clang_library name)
           ARCHIVE DESTINATION lib${LLVM_LIBDIR_SUFFIX}
           RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}")
 
-        if (LLVM_ENABLE_PDB)
-          install(FILES $<TARGET_PDB_FILE:${name}> DESTINATION "${CMAKE_INSTALL_BINDIR}" COMPONENT ${name} OPTIONAL)
-        endif()
-
         if (NOT LLVM_ENABLE_IDE)
           add_llvm_install_targets(install-${lib}
                                    DEPENDS ${lib}

@mayanez mayanez merged commit 165a3d6 into main Feb 12, 2025
7 of 9 checks passed
@mayanez mayanez deleted the revert-126675-build/cmakepdb-clang branch February 12, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants