Skip to content

[lldb] fix software breakpoint removing in multithreaded process while stepping #127506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[lldb] fix software breakpoint removing in multithreaded process while stepping #127506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1959,6 +1959,7 @@ void NativeProcessLinux::SignalIfAllThreadsStopped() {

// Clear any temporary breakpoints we used to implement software single
// stepping.
SetCurrentThreadID(m_pending_notification_tid);
for (const auto &thread_info : m_threads_stepping_with_breakpoint) {
Status error = RemoveBreakpoint(thread_info.second);
if (error.Fail())
Expand All @@ -1968,7 +1969,6 @@ void NativeProcessLinux::SignalIfAllThreadsStopped() {
m_threads_stepping_with_breakpoint.clear();

// Notify the delegate about the stop
SetCurrentThreadID(m_pending_notification_tid);
SetState(StateType::eStateStopped, true);
m_pending_notification_tid = LLDB_INVALID_THREAD_ID;
}
Expand Down