[Github][CI] Make the new premerge system fail jobs on errors #139359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
May 10, 2025
This patch makes the new premerge system report failures when the build errors out. We were previously not doing this to not notify people on failures as we were testing out the infra. This works towards making the new premerge system canonical and the deprecation of the old system. A launch announcement on Discourse will accompany this commit. Pull Request: llvm#139359
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis patch makes the new premerge system report failures when the build This works towards making the new premerge system canonical and the A launch announcement on Discourse will accompany this commit. Full diff: https://github.com/llvm/llvm-project/pull/139359.diff 1 Files Affected:
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 74ac80ba1b86f..3d29f220d18a8 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -42,9 +42,6 @@ jobs:
# Mark the job as a success even if the step fails so that people do
# not get notified while the new premerge pipeline is in an
# experimental state.
- # TODO(boomanaiden154): Remove this once the pipeline is stable and we
- # are ready for people to start recieving notifications.
- continue-on-error: true
run: |
git config --global --add safe.directory '*'
@@ -109,9 +106,6 @@ jobs:
# Mark the job as a success even if the step fails so that people do
# not get notified while the new premerge pipeline is in an
# experimental state.
- # TODO(boomanaiden154): Remove this once the pipeline is stable and we
- # are ready for people to start recieving notifications.
- continue-on-error: true
if: ${{ steps.vars.outputs.windows-projects != '' }}
shell: cmd
run: |
|
boomanaiden154
requested review from
tstellar,
dschuff,
lnihlen,
gburgessiv,
joker-eph,
Keenuts and
cmtice
joker-eph
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the new premerge system report failures when the build
errors out. We were previously not doing this to not notify people on
failures as we were testing out the infra.
This works towards making the new premerge system canonical and the
deprecation of the old system.
A launch announcement on Discourse will accompany this commit.