Skip to content

[CodeGenPrepare] Fix signed overflow #141487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
+11 −5
Merged

[CodeGenPrepare] Fix signed overflow #141487

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27723bb
[CodeGenPrepare] Fix signed overflow
mikael-nilsson-arm May 27, 2025
68d5c08
Merge branch 'main' into fix
mikael-nilsson-arm Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions llvm/lib/CodeGen/CodeGenPrepare.cpp
View file
Original file line number Diff line number Diff line change
@@ -5447,11 +5447,17 @@ bool AddressingModeMatcher::matchAddr(Value *Addr, unsigned Depth) {
TPT.getRestorationPoint();
if (ConstantInt *CI = dyn_cast<ConstantInt>(Addr)) {
if (CI->getValue().isSignedIntN(64)) {
// Fold in immediates if legal for the target.
AddrMode.BaseOffs += CI->getSExtValue();
if (TLI.isLegalAddressingMode(DL, AddrMode, AccessTy, AddrSpace))
return true;
AddrMode.BaseOffs -= CI->getSExtValue();
// Check if the addition would result in a signed overflow.
int64_t Result;
bool Overflow =
AddOverflow(AddrMode.BaseOffs, CI->getSExtValue(), Result);
if (!Overflow) {
// Fold in immediates if legal for the target.
AddrMode.BaseOffs = Result;
if (TLI.isLegalAddressingMode(DL, AddrMode, AccessTy, AddrSpace))
return true;
AddrMode.BaseOffs -= CI->getSExtValue();
}
}
} else if (GlobalValue *GV = dyn_cast<GlobalValue>(Addr)) {
// If this is a global variable, try to fold it into the addressing mode.