[AArch64][Subtarget] add missing direct include of Triple.h #143362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AArch64Subtarget.h` uses the complete type of `Triple`, but had only forward declared the class, which happend to be included through the following bottom-up path for example: "llvm/TargetParser/Triple.h" "llvm/MC/MCSubtargetInfo.h" "llvm/CodeGen/TargetSubtargetInfo.h"
|
@llvm/pr-subscribers-backend-aarch64 Author: Tomer Shafir (tomershafir) Changes
Full diff: https://github.com/llvm/llvm-project/pull/143362.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AArch64/AArch64Subtarget.h b/llvm/lib/Target/AArch64/AArch64Subtarget.h
index f5ffc72cae537..3a9a37426bb93 100644
--- a/llvm/lib/Target/AArch64/AArch64Subtarget.h
+++ b/llvm/lib/Target/AArch64/AArch64Subtarget.h
@@ -26,6 +26,7 @@
#include "llvm/CodeGen/RegisterBankInfo.h"
#include "llvm/CodeGen/TargetSubtargetInfo.h"
#include "llvm/IR/DataLayout.h"
+#include "llvm/TargetParser/Triple.h"
#define GET_SUBTARGETINFO_HEADER
#include "AArch64GenSubtargetInfo.inc"
@@ -33,7 +34,6 @@
namespace llvm {
class GlobalValue;
class StringRef;
-class Triple;
class AArch64Subtarget final : public AArch64GenSubtargetInfo {
public:
|
tomershafir
force-pushed
the
aarch64-subtarget-add-missing-direct-include
branch
from
33ad4c6 to
f5e1ca0
Compare
|
@davemgreen can you pls merge? I dont have access yet |
DhruvSrivastavaX
pushed a commit
to DhruvSrivastavaX/lldb-for-aix
that referenced
this pull request
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AArch64Subtarget.huses the complete type ofTriple, but had only forward declared the class, which happend to be included through the following bottom-up path for example: "llvm/TargetParser/Triple.h""llvm/MC/MCSubtargetInfo.h"
"llvm/CodeGen/TargetSubtargetInfo.h"