Skip to content

Fix missing module exports & broken localization test. #146269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

EricWF
Copy link
Member

@EricWF EricWF commented Jun 29, 2025

The mangled_name.pass.cpp test was checked in a few days ago, and this patch attempts to fix the build breakages it introduced.

The cryptic error from the breakage is:

When reproducing on my machine, I got additional diagnostics about missing exports for errc. The fix, I believe, is to re-export the errc header from the charconv module (or submodule).

The mangled_name.pass.cpp test was checked in a few days ago,
and this patch attempts to fix the build breakages it introduced.

The cryptic error from the breakage is:

When reproducing on my machine, I got additional diagnostics about
missing exports for `errc`. The fix, I believe, is to re-export the errc
header from the charconv module (or submodule).
@EricWF EricWF requested a review from a team as a code owner June 29, 2025 14:33
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jun 29, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 29, 2025

@llvm/pr-subscribers-libcxx

Author: Eric (EricWF)

Changes

The mangled_name.pass.cpp test was checked in a few days ago, and this patch attempts to fix the build breakages it introduced.

The cryptic error from the breakage is:

When reproducing on my machine, I got additional diagnostics about missing exports for errc. The fix, I believe, is to re-export the errc header from the charconv module (or submodule).


Full diff: https://github.com/llvm/llvm-project/pull/146269.diff

1 Files Affected:

  • (modified) libcxx/include/module.modulemap.in (+4-1)
diff --git a/libcxx/include/module.modulemap.in b/libcxx/include/module.modulemap.in
index f878e15d70b1a..2b3dfd2c9cced 100644
--- a/libcxx/include/module.modulemap.in
+++ b/libcxx/include/module.modulemap.in
@@ -934,7 +934,10 @@ module std [system] {
     module chars_format               { header "__charconv/chars_format.h" }
     module from_chars_floating_point  { header "__charconv/from_chars_floating_point.h" }
     module from_chars_integral        { header "__charconv/from_chars_integral.h" }
-    module from_chars_result          { header "__charconv/from_chars_result.h" }
+    module from_chars_result          {
+        header "__charconv/from_chars_result.h"
+        export std.system_error.errc // The result type contains errc
+    }
     module tables                     { header "__charconv/tables.h" }
     module to_chars                   { header "__charconv/to_chars.h" }
     module to_chars_base_10           { header "__charconv/to_chars_base_10.h" }

@EricWF EricWF changed the title Fix missing module exports & broken locatization test. Fix missing module exports & broken localization test. Jun 29, 2025
@EricWF EricWF closed this Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants