Fix missing module exports & broken localization test. #146269
Closed
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mangled_name.pass.cpp test was checked in a few days ago, and this patch attempts to fix the build breakages it introduced.
The cryptic error from the breakage is:
When reproducing on my machine, I got additional diagnostics about missing exports for
errc
. The fix, I believe, is to re-export the errc header from the charconv module (or submodule).