Skip to content

[NFC] [C++] [Modules] Mark P2615 as implemented and add test #147135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kish1n
Copy link
Contributor

@kish1n kish1n commented Jul 5, 2025

This is already implemented. See godbolt: https://godbolt.org/z/1ra4Ka8od

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jul 5, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 5, 2025

@llvm/pr-subscribers-clang-modules

@llvm/pr-subscribers-clang

Author: Ashwin Kishin Banwari (kish1n)

Changes

This is already implemented. See godbolt: https://godbolt.org/z/1ra4Ka8od


Full diff: https://github.com/llvm/llvm-project/pull/147135.diff

2 Files Affected:

  • (added) clang/test/SemaCXX/P2615.cpp (+11)
  • (modified) clang/www/cxx_status.html (+1-1)
diff --git a/clang/test/SemaCXX/P2615.cpp b/clang/test/SemaCXX/P2615.cpp
new file mode 100644
index 0000000000000..fed177c21bc79
--- /dev/null
+++ b/clang/test/SemaCXX/P2615.cpp
@@ -0,0 +1,11 @@
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+
+
+// RUN: %clang_cc1 -std=c++20 -verify -fsyntax-only %t/A.cpp
+
+//--- A.cpp
+// expected-no-diagnostics
+export module A;
+export namespace N {int x = 42;}
+export using namespace N;
diff --git a/clang/www/cxx_status.html b/clang/www/cxx_status.html
index 831f79f7cf17a..16e90a4dbb209 100755
--- a/clang/www/cxx_status.html
+++ b/clang/www/cxx_status.html
@@ -943,7 +943,7 @@ <h2 id="cxx20">C++20 implementation status</h2>
       </tr>
       <tr> <!-- from Kona 2022 -->
         <td><a href="https://wg21.link/P2615R1">P2615R1</a> (<a href="#dr">DR</a>)</td>
-        <td class="none" align="center">No</td>
+        <td class="full" align="center">Clang 17</td>
       </tr>
       <tr> <!-- from Issaquah 2023 -->
         <td><a href="https://wg21.link/P2788R0">P2788R0</a> (<a href="#dr">DR</a>)</td>

@kish1n
Copy link
Contributor Author

kish1n commented Jul 5, 2025

@ChuanqiXu9

@cor3ntin cor3ntin added the clang:modules C++20 modules and Clang Header Modules label Jul 5, 2025
Copy link
Member

@ChuanqiXu9 ChuanqiXu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. A small suggestion is, it is better to paste the link of the paper. So that I don't have to find it my self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:modules C++20 modules and Clang Header Modules clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants