-
Notifications
You must be signed in to change notification settings - Fork 14.6k
Remove extraneous addition of -X
flag in baremetal toolchain
#148855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Garvit Gupta (quic-garvgupt) ChangesCommit 597ee88 moved the -X flag to a new position in the baremetal toolchain's linker job, This patch removes the redundant flag, ensuring -X is passed only once. Full diff: https://github.com/llvm/llvm-project/pull/148855.diff 1 Files Affected:
diff --git a/clang/lib/Driver/ToolChains/BareMetal.cpp b/clang/lib/Driver/ToolChains/BareMetal.cpp
index e670696cd59ae..497f3330237b9 100644
--- a/clang/lib/Driver/ToolChains/BareMetal.cpp
+++ b/clang/lib/Driver/ToolChains/BareMetal.cpp
@@ -694,9 +694,6 @@ void baremetal::Linker::ConstructJob(Compilation &C, const JobAction &JA,
NeedCRTs)
CmdArgs.push_back(Args.MakeArgString(TC.GetFilePath(CRTEnd)));
- if (TC.getTriple().isRISCV())
- CmdArgs.push_back("-X");
-
// The R_ARM_TARGET2 relocation must be treated as R_ARM_REL32 on arm*-*-elf
// and arm*-*-eabi (the default is R_ARM_GOT_PREL, used on arm*-*-linux and
// arm*-*-*bsd).
|
Commit 597ee88 moved the -X flag to a new position in the baremetal toolchain's linker job, but unintentionally left the original instance in place. This patch removes the redundant flag, ensuring -X is passed only once. Change-Id: I05fa2d2ecd993d228bea2a15119b0df4059ca8ee
-X
flag in baremetal toolchain-X
flag in baremetal toolchain
Hi @petrhosek, if everything looks good, can you pls provide a LGTM? Thanks |
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/20070 Here is the relevant piece of the build log for the reference
|
/cherry-pick 81651e9 |
/pull-request #150089 |
Commit 597ee88 moved the -X flag to a new position in the baremetal toolchain's linker job,
but unintentionally left the original instance in place.
This patch removes the redundant flag, ensuring -X is passed only once.