Skip to content

[RISCV][NFC] Ensure files end with newline. #154457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025

Conversation

link-xyq
Copy link
Contributor

Add trailing newlines to the following files to comply with POSIX standards:

  • llvm/lib/Target/RISCV/RISCVInstrInfoXSpacemiT.td
  • llvm/test/MC/RISCV/xsmtvdot-invalid.s
  • llvm/test/MC/RISCV/xsmtvdot-valid.s

Closes #151706

@llvmbot
Copy link
Member

llvmbot commented Aug 20, 2025

@llvm/pr-subscribers-backend-risc-v

Author: Link (link-xyq)

Changes

Add trailing newlines to the following files to comply with POSIX standards:

  • llvm/lib/Target/RISCV/RISCVInstrInfoXSpacemiT.td
  • llvm/test/MC/RISCV/xsmtvdot-invalid.s
  • llvm/test/MC/RISCV/xsmtvdot-valid.s

Closes #151706


Full diff: https://github.com/llvm/llvm-project/pull/154457.diff

3 Files Affected:

  • (modified) llvm/lib/Target/RISCV/RISCVInstrInfoXSpacemiT.td (+1-1)
  • (modified) llvm/test/MC/RISCV/xsmtvdot-invalid.s (+1-1)
  • (modified) llvm/test/MC/RISCV/xsmtvdot-valid.s (+1-1)
diff --git a/llvm/lib/Target/RISCV/RISCVInstrInfoXSpacemiT.td b/llvm/lib/Target/RISCV/RISCVInstrInfoXSpacemiT.td
index 980931ea12a4f..91f8bd373b16d 100644
--- a/llvm/lib/Target/RISCV/RISCVInstrInfoXSpacemiT.td
+++ b/llvm/lib/Target/RISCV/RISCVInstrInfoXSpacemiT.td
@@ -136,4 +136,4 @@ def VMADOT3U  : RVInstSMTVDotSlide<SMT_VDot_Slide3, SMT_VDot_UU, "smt.vmadot3u",
 def VMADOT3SU : RVInstSMTVDotSlide<SMT_VDot_Slide3, SMT_VDot_SU, "smt.vmadot3su", "$vd, $vs1, $vs2">;
 def VMADOT3US : RVInstSMTVDotSlide<SMT_VDot_Slide3, SMT_VDot_US, "smt.vmadot3us", "$vd, $vs1, $vs2">;
 }
-}
\ No newline at end of file
+} // DecoderNamespace = "XSMT"
diff --git a/llvm/test/MC/RISCV/xsmtvdot-invalid.s b/llvm/test/MC/RISCV/xsmtvdot-invalid.s
index 9dce654ecc7f5..e4c48c5702888 100644
--- a/llvm/test/MC/RISCV/xsmtvdot-invalid.s
+++ b/llvm/test/MC/RISCV/xsmtvdot-invalid.s
@@ -49,4 +49,4 @@ smt.vmadot3us v2, v1, v2 # CHECK: :[[@LINE]]:19: error: invalid operand for inst
 smt.vmadot3   v1, v3, v2 # CHECK: :[[@LINE]]:15: error: invalid operand for instruction
 smt.vmadot3u  v1, v3, v2 # CHECK: :[[@LINE]]:15: error: invalid operand for instruction
 smt.vmadot3su v1, v3, v2 # CHECK: :[[@LINE]]:15: error: invalid operand for instruction
-smt.vmadot3us v1, v3, v2 # CHECK: :[[@LINE]]:15: error: invalid operand for instruction
\ No newline at end of file
+smt.vmadot3us v1, v3, v2 # CHECK: :[[@LINE]]:15: error: invalid operand for instruction
diff --git a/llvm/test/MC/RISCV/xsmtvdot-valid.s b/llvm/test/MC/RISCV/xsmtvdot-valid.s
index 9e66419b10e16..18df55d21d93a 100644
--- a/llvm/test/MC/RISCV/xsmtvdot-valid.s
+++ b/llvm/test/MC/RISCV/xsmtvdot-valid.s
@@ -111,4 +111,4 @@ smt.vmadot3su v12, v4, v10
 # CHECK-ENCODING: [0x2b,0x97,0xb3,0xe6]
 # CHECK-ERROR: instruction requires the following: 'XSMTVDot' (SpacemiT Vector Dot Product Extension){{$}}
 # CHECK-UNKNOWN: e6b3972b <unknown>
-smt.vmadot3us v14, v6, v11
\ No newline at end of file
+smt.vmadot3us v14, v6, v11

@tclin914
Copy link
Contributor

I think you should update your PR title to be like [RISCV] Ensure...

@link-xyq link-xyq force-pushed the fix/#151706-followup branch from f20c24f to 2ba0dc6 Compare August 20, 2025 02:51
@link-xyq link-xyq changed the title fix(file format): ensure files end with newline. [RISCV] Ensure files end with newline. Aug 20, 2025
@link-xyq
Copy link
Contributor Author

@tclin914 Thx! Title has Updated.

@link-xyq link-xyq force-pushed the fix/#151706-followup branch from 2ba0dc6 to e7f4e62 Compare August 20, 2025 02:59
@link-xyq link-xyq changed the title [RISCV] Ensure files end with newline. [RISCV][NFC] Ensure files end with newline. Aug 20, 2025
Copy link
Member

@lenary lenary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tclin914 tclin914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add trailing newlines to the following files to comply with POSIX standards:
- llvm/lib/Target/RISCV/RISCVInstrInfoXSpacemiT.td
- llvm/test/MC/RISCV/xsmtvdot-invalid.s
- llvm/test/MC/RISCV/xsmtvdot-valid.s

Closes llvm#151706
@link-xyq link-xyq force-pushed the fix/#151706-followup branch from e7f4e62 to 02256fc Compare August 20, 2025 06:29
@zqb-all
Copy link
Contributor

zqb-all commented Aug 20, 2025

LGTM

@zqb-all zqb-all merged commit 46e77eb into llvm:main Aug 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants