Skip to content

Product salability improvements fork #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

Product salability improvements fork #3243

wants to merge 29 commits into from

Conversation

@novikor
Copy link
Contributor

@novikor novikor commented Nov 15, 2020 •
edited by sidolov
Loading

See #3202

Description (*)

A common version for #3140 IsProductSalable/AreProdustsSalable composite products support and #3201: Load product salability data on-demand

Fixed Issues (if relevant)

  1. Fixes IsProductSalable/AreProdustsSalable composite products support. #3140 IsProductSalable/AreProdustsSalable composite products support
  2. Fixes Load product salability data on-demand #3201: Load product salability data on-demand

Manual testing scenarios (*)

Not now

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

This was referenced Nov 15, 2020
Open
Closed
@novikor
Copy link
Contributor Author

novikor commented Nov 15, 2020

@magento run all tests

@novikor
Copy link
Contributor Author

novikor commented Nov 18, 2020

@magento run Integration Tests

@novikor
Copy link
Contributor Author

novikor commented Nov 18, 2020

@magento run Functional Tests CE

novikor and others added 22 commits January 4, 2021 12:31
@novikor
Composite products support for IsProductSaleable.
3259aa0
@novikor
Refactoring.
5c05bde 
Apply code review changes.
@novikor
Fix static tests.
277444f
@novikor
Move product load after type discovery.
449903b
@novikor
Fix typo.
a8fe881
@novikor
Refactoring.
07b8b95 
Move bundle status check to plugin.
Move configurable plugin to around.
Both facts comes from fact for bundle and configurable produts, salability status is depends only on salability status of their children (and does not depend on the condition chain).
@novikor
Fix static tests, fix integration tests, code review fixes, revert un…
75d2aa6 
…neded changes.
@novikor
Composite products support for IsProductSaleable.
969d85d 
Fixed case when composite product has out of stock status.
@novikor
Composite products support for IsProductSaleable.
634edaa
@novikor
magento#3140:
ed96f69 
Fix static tests.
@novikor
Product salability improvements magento#3202.
dff2271 
Updated TODOs
@novikor
Product salability improvements magento#3202.
b902536 
Remove excess code.
@novikor
Load product salability data on-demand magento#3201: Moved product sa…
b9e33c8 
…lability calculation from observer to plugin method to be executed on demand.
@novikor
Load product salability data on-demand magento#3201. Moved plugins to…
dbacea1 
… isAvailable only.
@nmalevanec @novikor
Load product salability data on-demand magento#3201.
05d5a9c 
Fix tests.
@novikor
Load product salability data on-demand magento#3201.
a977217 
Fixed is salable logic.
@novikor
Load product salability data on-demand magento#3201.
77ed746
@novikor
Load product salability data on-demand magento#3201.
8765d01 
Restored Bundles support plugin for IsProductSalableChain
@novikor
Load product salability data on-demand magento#3201.
2340018 
Tests fix and stabilizations.
@novikor
Load product salability data on-demand magento#3201.
d106eb0 
    Tests fix and stabilizations.
@novikor
Load product salability data on-demand magento#3201.
b22f0d2 
Drop test of removed logic.
@novikor
Load product salability data on-demand magento#3201.
ed7f2a5 
Small refactoring.
OleksandrKravchuk and others added 2 commits January 4, 2021 12:31
@novikor
Load product salability data on-demand magento#3201.
d612570 
Fix Static Tests.
@novikor
IsProductSalable/AreProdustsSalable composite products support. magen…
9ed24ae 
…to#3140

Load product salability data on-demand magento#3201.
Fixed IsProductSalable for products with calculated SKUs
@novikor novikor force-pushed the product-salability-improvements-fork branch from ee38c3e to 9ed24ae Compare January 4, 2021 10:32
@novikor
Copy link
Contributor Author

novikor commented Jan 4, 2021

@magento run Integration Tests

@novikor
Copy link
Contributor Author

novikor commented Jan 4, 2021

@magento run Functional Tests CE

@novikor
IsProductSalable/AreProdustsSalable composite products support. magen…
a122e9b 
…to#3140

Load product salability data on-demand magento#3201.
Removed abandoned test after covered class removal
@novikor
Copy link
Contributor Author

novikor commented Jan 5, 2021

@magento run Integration Tests

@novikor
Copy link
Contributor Author

novikor commented Jan 5, 2021

@magento run Functional Tests CE

@novikor
IsProductSalable/AreProdustsSalable composite products support. magen…
c3f1b3d 
…to#3140

Load product salability data on-demand magento#3201.
Verify product statuses during salability calculation for composite products using default functionality.
@novikor
Copy link
Contributor Author

novikor commented Jan 19, 2021

@magento run all tests

@novikor novikor self-assigned this Jan 19, 2021
@novikor
Copy link
Contributor Author

novikor commented Jan 20, 2021

The development part seems to be finished.

However, there are some test cases that should be covered:

  • Bundle product with disabled items frontend availability (MFTF and/or Integration):
  • Custom stock with custom source, with sales channel assigned;
  • A bundle product with a single simple bundle item assigned to the custom source, In stock;
  • The simple product has Enable Product set to No
  • Expected result: bundle product is out of stock and not available on the frontend.
  • Invalid Actual result example:
    image
  • Configurable product with disabled children frontend availability (Integration, already covered by MFTF: AdminConfigurableProductWithDisabledChildrenOnAdditionalStockTest):
  • Custom stock with custom source, with sales channel assigned;
  • A configurable product with a single simple child item assigned to the custom source, In stock;
  • The simple product has Enable Product set to No
  • Expected result: configurable product is out of stock and not available on the frontend (\Magento\Catalog\Model\Product::isSalable must return false).
  • Cover AreProductsSalableInterface Configurable Product compatibility (Integration)
  • Cover AreProductsSalableInterface Bundle Product compatibility (Integration)

@swnsma .

@novikor
Copy link
Contributor Author

novikor commented Jan 21, 2021

@magento run all tests

@sidolov
Copy link
Contributor

sidolov commented Feb 1, 2021

@magento run all tests

@sidolov sidolov changed the base branch from 1.2-develop to develop November 11, 2021 17:48
@engcom-Hotel engcom-Hotel moved this to Review in Progress in Inventory - Pull Request Progress Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@swnsma swnsma

@novikor novikor

Labels

Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: advanced Award: bug fix Award: category of expertise Progress: review

Projects

Inventory - Pull Request Progress
Status: Review in Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Load product salability data on-demand IsProductSalable/AreProdustsSalable composite products support.

4 participants

@novikor @sidolov @swnsma @nmalevanec