Product salability improvements #3202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 30, 2020
novikor
force-pushed
the
product-salability-improvements
branch
from
a850ad6 to
a52a4c9
Compare
Apply code review changes.
Move bundle status check to plugin. Move configurable plugin to around. Both facts comes from fact for bundle and configurable produts, salability status is depends only on salability status of their children (and does not depend on the condition chain).
Fixed case when composite product has out of stock status.
novikor
force-pushed
the
product-salability-improvements
branch
from
e030d0f to
943a0b4
Compare
Updated TODOs
4 tasks
Remove excess code.
4 tasks
Product salability improvements #3202.
…y calculation from observer to plugin method to be executed on demand.
Fix tests.
Fixed is salable logic.
Restored Bundles support plugin for IsProductSalableChain
Tests fix and stabilizations.
Tests fix and stabilizations.
Drop test of removed logic.
Small refactoring.
Fix Static Tests.
…-demand-fork Load product salability data on demand
…deman Load product salability data on demand
novikor
added a commit
to novikor/inventory
that referenced
this pull request
Nov 15, 2020
Updated TODOs
novikor
pushed a commit
to novikor/inventory
that referenced
this pull request
Nov 15, 2020
Remove excess code.
4 tasks
Contributor
Author
|
This PR is officially dead. We have #3243 now instead. |
novikor
added a commit
to novikor/inventory
that referenced
this pull request
Jan 4, 2021
Updated TODOs
novikor
pushed a commit
to novikor/inventory
that referenced
this pull request
Jan 4, 2021
Remove excess code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
A common version for #3140 IsProductSalable/AreProdustsSalable composite products support and #3201: Load product salability data on-demand
Fixed Issues (if relevant)
Manual testing scenarios (*)
Not now
Contribution checklist (*)