feat(WalletBase): add SignMessage(string) convenience overload#274
Open
mstevens843 wants to merge 1 commit intomagicblock-labs:mainfrom
Open
feat(WalletBase): add SignMessage(string) convenience overload#274mstevens843 wants to merge 1 commit intomagicblock-labs:mainfrom
mstevens843 wants to merge 1 commit intomagicblock-labs:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughAdded a string overload to the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SignMessage()only acceptsbyte[]. Every caller must manually convert strings viaEncoding.UTF8.GetBytes()before signing, adding unnecessary boilerplate for themost common use case — signing human-readable messages.
Discovered while building a Unity MWA example app on Solana Seeker hardware with Seed Vault
(unity-solana-mwa-example). Documented as Point 6 in #273.
Solution
Added
SignMessage(string message)overload toIWalletBaseandWalletBasethat handles UTF-8 encoding internally, delegating to the existingSignMessage(byte[]).All derived wallet classes (
InGameWallet,SolanaMobileWalletAdapter,SolanaWalletAdapterWebGL,PhantomDeepLink,SolanaWalletAdapter) inherit the new overloadautomatically — zero changes required in implementations.
Before & After Screenshots
BEFORE:
AFTER:
Other changes (e.g. bug fixes, small refactors)
None. Purely additive — no existing signatures or behavior modified.
Deploy Notes
No new scripts or dependencies. Drop-in enhancement to existing API surface.
Summary by CodeRabbit