Skip to content

feat(WalletBase): add SignMessage(string) convenience overload #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mstevens843 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(WalletBase): add SignMessage(string) convenience overload #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Runtime/codebase/IWalletBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,13 @@ public interface IWalletBase
/// <returns></returns>
Task<byte[]> SignMessage(byte[] message);

/// <summary>
/// Sign a UTF-8 encoded string message
/// </summary>
/// <param name="message">The string message to sign</param>
/// <returns>The signature bytes</returns>
Task<byte[]> SignMessage(string message);

/// <summary>
/// Sign and send a transaction
/// </summary>
Expand Down
11 changes: 11 additions & 0 deletions Runtime/codebase/WalletBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System;
using System.Collections.Generic;
using System.Text;
using System.Linq;
using System.Threading.Tasks;
using Cysharp.Threading.Tasks;
Expand Down Expand Up @@ -264,6 +265,16 @@ public virtual async Task<RequestResult<string>> SignAndSendTransaction
/// <inheritdoc />
public abstract Task<byte[]> SignMessage(byte[] message);

/// <summary>
/// Sign a UTF-8 encoded string message
/// </summary>
/// <param name="message">The string message to sign</param>
/// <returns>The signature bytes</returns>
public Task<byte[]> SignMessage(string message)
{
return SignMessage(Encoding.UTF8.GetBytes(message));
}

/// <summary>
/// Airdrop sol on wallet
/// </summary>
Expand Down