Skip to content

refactor: redesign zero-copy types to make them simpler, faster and less-error prone#67

Open
snawaz wants to merge 8 commits intosnawaz/variable-layout-viewfrom
snawaz/zc-types
Open

refactor: redesign zero-copy types to make them simpler, faster and less-error prone#67
snawaz wants to merge 8 commits intosnawaz/variable-layout-viewfrom
snawaz/zc-types

Conversation

@snawaz
Copy link
Copy Markdown
Contributor

@snawaz snawaz commented Apr 11, 2026

  • Breaking changes due to enforcement of alignment requirements and the fixed_layout types.
  • Redesign zero-copy types to make them simpler, faster and less-error prone.
  • Use 8 bytes for instruction discriminator, so as to enforce 8-byte alignment for instruction-data.
  • Split instructions into two enum types:
    • enum ESplInstruction defined in the api crate.
    • enum ESplInternalInstruction defined in the program crate and made private.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 11, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: de49c789-ed26-4969-b96d-5a1f6c8571e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch snawaz/zc-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor Author

snawaz commented Apr 11, 2026

@snawaz snawaz force-pushed the snawaz/variable-layout-view branch from fb07c41 to 902d085 Compare April 11, 2026 19:36
@snawaz snawaz force-pushed the snawaz/variable-layout-view branch from 902d085 to d032aab Compare April 12, 2026 01:12
@snawaz snawaz force-pushed the snawaz/variable-layout-view branch from 1516315 to 1e8e1b1 Compare April 12, 2026 13:05
@snawaz snawaz force-pushed the snawaz/zc-types branch 2 times, most recently from c0b5422 to 48bde04 Compare April 12, 2026 16:55
@snawaz snawaz force-pushed the snawaz/variable-layout-view branch from 1e8e1b1 to 29dd07a Compare April 12, 2026 16:55
@snawaz snawaz force-pushed the snawaz/variable-layout-view branch from 29dd07a to f45ff82 Compare April 12, 2026 19:21
@snawaz snawaz force-pushed the snawaz/zc-types branch 4 times, most recently from ae88114 to 2364e2d Compare April 12, 2026 20:44
@snawaz snawaz marked this pull request as ready for review April 12, 2026 21:15
@snawaz snawaz force-pushed the snawaz/variable-layout-view branch 2 times, most recently from 5126dba to 78bc151 Compare April 13, 2026 11:20
@snawaz snawaz requested a review from GabrielePicco April 13, 2026 11:21
@snawaz snawaz force-pushed the snawaz/variable-layout-view branch from 78bc151 to e625532 Compare April 14, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant