Skip to content

refactor: heap implemetation#68

Open
snawaz wants to merge 1 commit intosnawaz/zc-typesfrom
snawaz/heap
Open

refactor: heap implemetation#68
snawaz wants to merge 1 commit intosnawaz/zc-typesfrom
snawaz/heap

Conversation

@snawaz
Copy link
Copy Markdown
Contributor

@snawaz snawaz commented Apr 11, 2026

  • Breaking changes (not user-facing though) only in the layout of TransferQueueHeader.
  • Prefer const var instead of const fn for constant values.
  • Optimize head_push() and head_pop() by avoiding swap which unecessarily writes extra 96 bytes in each iteration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 11, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d2c2980f-0a50-4a26-80ea-b36ed3f836a6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch snawaz/heap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor Author

snawaz commented Apr 11, 2026

@snawaz snawaz force-pushed the snawaz/heap branch 2 times, most recently from 2bb604e to 4a11113 Compare April 12, 2026 01:12
@snawaz snawaz force-pushed the snawaz/zc-types branch 2 times, most recently from b988824 to 57198c7 Compare April 12, 2026 08:44
@snawaz snawaz force-pushed the snawaz/heap branch 2 times, most recently from 6f21915 to 855bce5 Compare April 12, 2026 13:05
@snawaz snawaz changed the base branch from snawaz/zc-types to graphite-base/68 April 12, 2026 16:55
@snawaz snawaz force-pushed the graphite-base/68 branch from c0b5422 to 2364e2d Compare April 12, 2026 20:49
@snawaz snawaz changed the base branch from graphite-base/68 to snawaz/zc-types April 12, 2026 20:49
@snawaz snawaz marked this pull request as ready for review April 12, 2026 21:15
@snawaz snawaz force-pushed the snawaz/zc-types branch 2 times, most recently from be050ad to 3de1482 Compare April 13, 2026 11:20
@snawaz snawaz requested a review from GabrielePicco April 13, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant