test(tools): comprehensive test suite for http_request truncation wrapper (+36 tests) - #140
Open
manus-use wants to merge 1 commit into
Open
test(tools): comprehensive test suite for http_request truncation wrapper (+36 tests)#140manus-use wants to merge 1 commit into
manus-use wants to merge 1 commit into
Conversation
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a comprehensive test suite for the
http_requesttruncation wrapper (src/manus_agent/tools/http_request.py) — 36 fully-mocked tests covering all truncation logic paths.What's tested
Why this matters
http_request.pyis the universal HTTP wrapper used by every tool that makes external API calls. Its truncation logic (per-item cap → proportional total reduction) prevents context-window blowouts, but had zero test coverage. The logic includes non-trivial proportional math and multiple phases that can interact.Existing PRs checked (no overlap)
None of the above test
http_request.py— this is the first test coverage for this module.Test results
All existing tests continue to pass. Ruff check/format clean.