Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Oct 19, 2026
mrousavy
marked this pull request as ready for review
October 19, 2026 20:27
mrousavy
added this pull request to stack #1817
October 19, 2026 22:04
mrousavy
force-pushed
the
mrousavy/v1-enable-callback-tests
branch
from
October 20, 2026 08:37
d8fe55c to
8f63d9f
Compare
mrousavy
removed this pull request from stack #1817
October 20, 2026 08:55
mrousavy
added this pull request to stack #1823
October 20, 2026 08:55
mrousavy
force-pushed
the
mrousavy/v1-enable-callback-tests
branch
from
October 20, 2026 09:04
8f63d9f to
17834ee
Compare
mrousavy
added a commit
that referenced
this pull request
Oct 20, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1808.
Fix the two fixture bugs behind the callback exclusions: Swift's closed range traps when the requested call count is zero, and C++ uses
future.wait()without reading a rejected Promise's error. Use a safe iteration range andfuture.get().Re-enable those tests and the Swift throwing synchronous callback case. Its old exclusion refers to a bridge that has since been replaced by exception handling through Result. Remove the stale TODOs and all callback exclusions, including the rejection exclusion for the shared C++ Android implementation.
Validation on Xcode 27.1 / Swift 6.4 / iOS 27.0: