Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Oct 19, 2026
mrousavy
marked this pull request as ready for review
October 19, 2026 20:27
mrousavy
added this pull request to stack #1817
October 19, 2026 22:04
mrousavy
changed the title
mrousavy
removed this pull request from stack #1817
October 20, 2026 08:55
mrousavy
added this pull request to stack #1823
October 20, 2026 08:55
mrousavy
added a commit
that referenced
this pull request
Oct 20, 2026
* test: update standalone assertions for v1 APIs * fix: unify Swift and C++ enum conversion errors * fix: keep Swift enum validation independent
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1807.
Give Swift enum conversion the same errors as C++ while keeping its own validation and member switches. Invalid values retain errors such as
Cannot convert "diesel" to enum Powertrain - invalid value!; wrong-type and numeric range errors use the existing JSI accessors and numeric helper. JS-to-Swift conversion does not call the generated C++ enum converter. This also covers enums in arrays, optional properties and struct fields. Remove the Swift-specific expectations and add shared regression cases for those paths.Update the remaining standalone assertions for the V1 APIs: qualified registry names, JS callback identity, native ArrayBuffer storage, disposed-object metadata, and the different descriptors used by the handwritten C++ and registered Swift Base/Child fixtures.
Validated locally on Xcode 27.1 / Swift 6.4 / iOS 27.0: the stack through #1809 passes all 1,485 JS cases and 13 native runner tests in the Default configuration. Nitrogen and runner typechecks, all five helper tests, and bundling pass. The three existing iOS callback exclusions remain in this PR; #1809 fixes the fixtures and enables them.