Mle 21676/HAProxy image can only be define in the subchart values.yaml file #324
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces default image configuration for the HAProxy subchart so that users can set repository, tag, and pullPolicy directly in charts/values.yaml.
- Adds an
imageblock underhaproxywithrepository,tag, andpullPolicydefaults - Ensures the HAProxy subchart can reference these values for its container image
Files not reviewed (2)
- Jenkinsfile: Language not supported
- makefile: Language not supported
| @@ -348,6 +348,10 @@ logCollection: | |||
| ## It also support multi-statement transaction and ODBC connections. | |||
| haproxy: | |||
| enabled: false | |||
There was a problem hiding this comment.
Consider adding a comment block describing the purpose and acceptable values for the new image keys (repository, tag, pullPolicy) so that users understand how to override them.
Suggested change
| enabled: false | |
| enabled: false | |
| ## Configuration for the HAProxy container image | |
| ## repository: The container image repository for HAProxy. Default is "haproxytech/haproxy-alpine". | |
| ## tag: The specific version of the HAProxy image to use. Default is "2.9.4". | |
| ## pullPolicy: The image pull policy. Acceptable values are "Always", "IfNotPresent", and "Never". Default is "IfNotPresent". |
Copilot uses AI. Check for mistakes.
Comment on lines
+353
to
+354
| tag: "2.9.4" | ||
| pullPolicy: IfNotPresent |
There was a problem hiding this comment.
[nitpick] Using a specific image tag is fine, but consider documenting or automating tag updates (e.g., via Dependabot or a chart version matrix) to avoid stale versions.
Suggested change
| tag: "2.9.4" | |
| pullPolicy: IfNotPresent | |
| tag: "{{ .Values.haproxy.image.tag }}" | |
| pullPolicy: IfNotPresent | |
| # Consider automating updates using Dependabot or a version matrix. |
Copilot uses AI. Check for mistakes.
pengzhouml
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.