-
Notifications
You must be signed in to change notification settings - Fork 17
Mle 21676/HAProxy image can only be define in the subchart values.yaml file #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4301f95
Add BlackDuck scan
7254949
Update job names and email status
f7ebb69
Merge pull request #316 from vitalykorolev/MLE-19837_add-blackduck-scan
vitalykorolev ca74c8b
add HAP image in main values
rwinieski afed5b3
update Readme
rwinieski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
import groovy.json.JsonSlurperClassic | ||
|
||
emailList = '[email protected], [email protected], [email protected], [email protected], [email protected], [email protected]' | ||
emailSecList = '[email protected], [email protected]' | ||
emailSecList = '[email protected]' | ||
gitCredID = 'marklogic-builder-github' | ||
JIRA_ID = '' | ||
JIRA_ID_PATTERN = /(?i)(MLE)-\d{3,6}/ | ||
|
@@ -103,7 +103,7 @@ def getReviewState() { | |
return reviewState | ||
} | ||
|
||
void resultNotification(message) { | ||
void resultNotification(status) { | ||
def author, authorEmail, emailList | ||
if (env.CHANGE_AUTHOR) { | ||
author = env.CHANGE_AUTHOR.toString().trim().toLowerCase() | ||
|
@@ -117,11 +117,11 @@ void resultNotification(message) { | |
jira_email_body = "${email_body} <br><br><b>Jira URL: </b><br><a href='${jira_link}'>${jira_link}</a>" | ||
|
||
if (JIRA_ID) { | ||
def comment = [ body: "Jenkins pipeline build result: ${message}" ] | ||
def comment = [ body: "Jenkins pipeline build result: ${status}" ] | ||
jiraAddComment site: 'JIRA', idOrKey: JIRA_ID, failOnError: false, input: comment | ||
mail charset: 'UTF-8', mimeType: 'text/html', to: "${emailList}", body: "${jira_email_body}", subject: "${message}: ${env.JOB_NAME} #${env.BUILD_NUMBER} - ${JIRA_ID}" | ||
mail charset: 'UTF-8', mimeType: 'text/html', to: "${emailList}", body: "${jira_email_body}", subject: "🥷 ${status}: ${env.JOB_NAME} #${env.BUILD_NUMBER} - ${JIRA_ID}" | ||
} else { | ||
mail charset: 'UTF-8', mimeType: 'text/html', to: "${emailList}", body: "${email_body}", subject: "${message}: ${env.JOB_NAME} #${env.BUILD_NUMBER}" | ||
mail charset: 'UTF-8', mimeType: 'text/html', to: "${emailList}", body: "${email_body}", subject: "🥷 ${status}: ${env.JOB_NAME} #${env.BUILD_NUMBER}" | ||
} | ||
} | ||
|
||
|
@@ -147,6 +147,11 @@ void imageScan() { | |
} | ||
|
||
sh '''rm -f dep-image-scan.txt''' | ||
|
||
// trigger BlackDuck scan | ||
def rawImageList = readFile(file: 'helm_image.list').trim() | ||
def imageList = rawImageList.endsWith(',') ? rawImageList[0..-2] : rawImageList | ||
build job: 'securityscans/Blackduck/KubeNinjas/kubernetes-helm', wait: false, parameters: [ string(name: 'branch', value: "${env.BRANCH_NAME}"), string(name: 'CONTAINER_IMAGES', value: "${imageList}") ] | ||
} | ||
|
||
void publishTestResults() { | ||
|
@@ -261,13 +266,16 @@ pipeline { | |
sh "rm -rf $WORKSPACE/test/test_results/" | ||
} | ||
success { | ||
resultNotification('BUILD SUCCESS ✅') | ||
resultNotification('✅ Success') | ||
} | ||
failure { | ||
resultNotification('BUILD ERROR ❌') | ||
resultNotification('❌ Failure') | ||
} | ||
unstable { | ||
resultNotification('BUILD UNSTABLE ❌') | ||
resultNotification('⚠️ Unstable') | ||
} | ||
aborted { | ||
resultNotification('🚫 Aborted') | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -348,6 +348,10 @@ logCollection: | |||||||||||
## It also support multi-statement transaction and ODBC connections. | ||||||||||||
haproxy: | ||||||||||||
enabled: false | ||||||||||||
image: | ||||||||||||
repository: haproxytech/haproxy-alpine | ||||||||||||
tag: "2.9.4" | ||||||||||||
pullPolicy: IfNotPresent | ||||||||||||
Comment on lines
+353
to
+354
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] Using a specific image tag is fine, but consider documenting or automating tag updates (e.g., via Dependabot or a chart version matrix) to avoid stale versions.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||||||
|
||||||||||||
## Name of an existing configmap with configuration for HAProxy | ||||||||||||
existingConfigmap: marklogic-haproxy | ||||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a comment block describing the purpose and acceptable values for the new
image
keys (repository
,tag
,pullPolicy
) so that users understand how to override them.Copilot uses AI. Check for mistakes.