-
Notifications
You must be signed in to change notification settings - Fork 0
19964: Fix broken links in the documentation #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @martin-augment, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the quality and maintainability of the project's documentation. It addresses and resolves various broken and outdated links, ensuring that users and contributors can access accurate and current information seamlessly. The changes span across multiple guides, correcting paths to internal documentation, external resources, and API references. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughThis pull request updates documentation files with corrected hyperlinks, reorganized reference paths, and version updates. Changes include redirecting internal API documentation links to reflect restructured module paths, removing obsolete reference links, updating external resource URLs with corrected domains and protocols, and bumping a DataFusion version reference from 25.0.0 to 26.0.0. All modifications are isolated to documentation files with no functional code or API surface changes. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request ReviewSummaryThis PR fixes broken documentation links across multiple files. The changes update URLs that have become outdated due to documentation restructuring or API changes. Code Quality ✅Excellent - The changes are focused and precise:
Changes Breakdown1. Contributor Guide Link (howtos.md:190)
2. API Documentation Links (extending-sql.md:337)
3. Removed Dead Link (adding-udfs.md:586)
4. Multiple API Path Corrections (table-constraints.md:40-42)
5. Arrow Array Type Links (arrow-introduction.md:229-230)
6. Read Options Links (arrow-introduction.md:244-245)
7. External Resource Links (concepts-readings-events.md)
8. Version Update (example-usage.md:106)
Potential Issues1. Version Consistency (example-usage.md)The PR updates the DataFusion version from 25.0.0 to 26.0.0 but doesn't update the Arrow version dependencies mentioned in the example. Please verify:
Recommendations
Test CoverageN/A - Documentation-only changes. However, consider:
Security Concerns✅ None - Documentation links only Performance Considerations✅ None - No code changes Overall AssessmentLGTM with minor suggestion - This is a solid documentation maintenance PR. The link updates appear correct and well-researched. The only minor concern is ensuring the version example is fully consistent. Great work keeping the documentation current! 🎯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes several broken links in the documentation, which is a great improvement. Most of the changes are correct and improve the quality of the docs. I've found one small issue in docs/source/user-guide/example-usage.md where a version update has introduced an inconsistency in the dependency information. I've left a comment with a suggestion for a fix. Otherwise, the changes look good.
| ``` | ||
|
|
||
| For example, [DataFusion `25.0.0` dependencies] require `arrow` | ||
| For example, [DataFusion `26.0.0` dependencies] require `arrow` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating the DataFusion version to 26.0.0 is a good step, this change makes the following line about the required arrow version incorrect. According to crates.io, DataFusion 26.0.0 depends on arrow 40.0.0, not 39.0.0 as stated on the next line.
Please update the arrow versions on line 107 to maintain the example's accuracy. A correct statement would be:
For example, [DataFusion `26.0.0` dependencies] require `arrow`
`40.0.0`. If instead you used `arrow` `41.0.0` in your project you may
see errors such as:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value:useful; category:documentation; feedback:The Gemini AI reviewer is correct! If the example needs to use DataFusion 26.0.0 then the version of its arrow dependency should be increased too. DataFusion 26.0.0 depends on 40.0.0, not on 39.0.0.
🤖 Augment PR SummarySummary: Fixes multiple broken links across the documentation by updating targets to current DataFusion/Arrow docs and external URLs. 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ``` | ||
|
|
||
| For example, [DataFusion `25.0.0` dependencies] require `arrow` | ||
| For example, [DataFusion `26.0.0` dependencies] require `arrow` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value:useful; category:documentation; feedback:The Augment AI reviewer is correct! If the example needs to use DataFusion 26.0.0 then the version of its arrow dependency should be increased too. DataFusion 26.0.0 depends on 40.0.0, not on 39.0.0.
value:useful; category:documentation; feedback:The Claude AI reviewer is correct! If the example needs to use DataFusion 26.0.0 then the version of its |
19964: To review by AI