-
Notifications
You must be signed in to change notification settings - Fork 0
19964: Fix broken links in the documentation #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,7 +103,7 @@ exported by DataFusion, for example: | |
| use datafusion::arrow::datatypes::Schema; | ||
| ``` | ||
|
|
||
| For example, [DataFusion `25.0.0` dependencies] require `arrow` | ||
| For example, [DataFusion `26.0.0` dependencies] require `arrow` | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. value:useful; category:documentation; feedback:The Augment AI reviewer is correct! If the example needs to use DataFusion 26.0.0 then the version of its |
||
| `39.0.0`. If instead you used `arrow` `40.0.0` in your project you may | ||
| see errors such as: | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating the DataFusion version to
26.0.0is a good step, this change makes the following line about the requiredarrowversion incorrect. According tocrates.io,DataFusion 26.0.0depends onarrow 40.0.0, not39.0.0as stated on the next line.Please update the
arrowversions on line 107 to maintain the example's accuracy. A correct statement would be:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value:useful; category:documentation; feedback:The Gemini AI reviewer is correct! If the example needs to use DataFusion 26.0.0 then the version of its
arrowdependency should be increased too. DataFusion 26.0.0 depends on 40.0.0, not on 39.0.0.